Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 6777010: Add test suite for the preparser. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add test suite for the preparser. The test suite builds the preparser test program and runs it on each .js file in the test/preparser directory. Currently it only checks that preparsing runs without crashing or erroring. This also implicitly tests that the preparser library can be built. TEST=test/preparser/*.js Committed: http://code.google.com/p/v8/source/detail?r=7436

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typos in debug mode code. #

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -116 lines) Patch
M SConstruct View 1 1 chunk +1 line, -1 line 0 comments Download
M preparser/preparser-process.cc View 1 2 2 chunks +77 lines, -114 lines 0 comments Download
A test/preparser/empty.js View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A test/preparser/functions-only.js View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A test/preparser/non-alphanum.js View 1 1 chunk +34 lines, -0 lines 0 comments Download
A test/preparser/symbols-only.js View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A test/preparser/testcfg.py View 1 chunk +90 lines, -0 lines 0 comments Download
M tools/test.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 8 months ago (2011-03-30 12:57:45 UTC) #1
Mads Ager (chromium)
LGTM, thanks! http://codereview.chromium.org/6777010/diff/1/preparser/preparser-process.cc File preparser/preparser-process.cc (right): http://codereview.chromium.org/6777010/diff/1/preparser/preparser-process.cc#newcode40 preparser/preparser-process.cc:40: // into memory), reads it, and prints ...
9 years, 8 months ago (2011-03-30 13:35:03 UTC) #2
Lasse Reichstein
9 years, 8 months ago (2011-03-30 13:58:58 UTC) #3
http://codereview.chromium.org/6777010/diff/1/preparser/preparser-process.cc
File preparser/preparser-process.cc (right):

http://codereview.chromium.org/6777010/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:40: // into memory), reads it, and prints the
resulting preparser data on
Done.

Powered by Google App Engine
This is Rietveld 408576698