src/x64/codegen-x64.cc - Issue 6777007: Add thread-safety to creation of MemCopy and modulo functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 6777007: Add thread-safety to creation of MemCopy and modulo functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add Release_Store to change. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index dc999b5780b6711d58bcc75898b284b9651687f3..c8f1c04a6d7532d705eaa8b4df1b8df6808b0a32 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -8824,7 +8824,10 @@ ModuloFunction CreateModuloFunction() {

CodeDesc desc;

masm.GetCode(&desc);

- // Call the function from C++.

+ // Make sure that the compiled code is visible to all threads before

+ // returning the pointer to it.

+ MemoryBarrier();

+ // Call the function from C++ through this pointer.

return FUNCTION_CAST<ModuloFunction>(buffer);

}

« no previous file with comments | « src/v8utils.h ('k') | test/cctest/test-utils.cc » ('j') | no next file with comments »