Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 6776011: Fix the Cygwin build (Closed)

Created:
9 years, 8 months ago by piscisaureus
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix the Cygwin build after isolates merge. Patch by Bert Belder. Committed: http://code.google.com/p/v8/source/detail?r=7447

Patch Set 1 : foobar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -103 lines) Patch
M src/platform-cygwin.cc View 10 chunks +163 lines, -103 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
piscisaureus
Pretty boring patch to fix the Cygwin port. Everything is from either platform-linux.cc or platform-win32.cc.
9 years, 8 months ago (2011-03-30 11:35:48 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-03-30 16:09:45 UTC) #2
LGTM

will land, thanks for fixing it Bert.

Powered by Google App Engine
This is Rietveld 408576698