Issue 6776009: Heap profiler: emit more descriptive names for system objects and properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6776009: Heap profiler: emit more descriptive names for system objects and properties. (Closed)

Created:
9 years, 8 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Heap profiler: emit more descriptive names for system objects and properties. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7438

Patch Set 2 : Comments addressed, compilation fixed #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -18 lines)			Patch
M	src/profile-generator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/profile-generator.cc	View	1	11 chunks	+72 lines, -13 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM http://codereview.chromium.org/6776009/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/6776009/diff/1/src/profile-generator.cc#newcode1764 src/profile-generator.cc:1764: bool process_field_marks = true) Are there usages left ...

9 years, 8 months ago (2011-03-30 13:26:37 UTC) #2

mnaganov (inactive)

9 years, 8 months ago (2011-03-30 13:45:36 UTC) #3

http://codereview.chromium.org/6776009/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/6776009/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1764: bool process_field_marks = true)
On 2011/03/30 13:26:37, Vitaly Repeshko wrote:
> Are there usages left where this parameter is false?

Actually, no. OK, let's remove the conditional.

Expand Messages | Collapse Messages

Issue 6776009: Heap profiler: emit more descriptive names for system objects and properties. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comments addressed, compilation fixed #

Messages