Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 6775005: iwyu: Cleanup in the following files: (Closed)

Created:
9 years, 9 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, GeorgeY, Ilya Sherman, dhollowa
Visibility:
Public.

Description

iwyu: Cleanup in the following files: * autofill_download.cc * autofill_ie_toolbar_import_win.cc * autofill_field.h * autofill_metrics.cc * autofill_profile.cc * autofill_type.cc * autofill_xml_parser.cc * contact_info.cc * credit_card.cc * credit_card_field.cc * fax_number.h * form_field.cc BUG=none TEST=none R=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79839

Patch Set 1 #

Total comments: 6

Patch Set 2 : Win fix 1. #

Patch Set 3 : Unit test fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -21 lines) Patch
M chrome/browser/autofill/address_field_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_download.h View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_download.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_download_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_field.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_ie_toolbar_import_win.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_ie_toolbar_import_win.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_profile.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_profile.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_type.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_xml_parser.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/autofill/contact_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/contact_info.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autofill/credit_card.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autofill/credit_card.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/autofill/credit_card_field.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/autofill/credit_card_field.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autofill/credit_card_field_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/fax_number.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autofill/form_field.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/form_field.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/autofill/form_field_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/phone_field_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years, 9 months ago (2011-03-29 21:23:48 UTC) #1
dhollowa
Looks like Windows is not compiling. And some puzzles below. http://codereview.chromium.org/6775005/diff/1/chrome/browser/autofill/autofill_download.cc File chrome/browser/autofill/autofill_download.cc (right): http://codereview.chromium.org/6775005/diff/1/chrome/browser/autofill/autofill_download.cc#newcode23 ...
9 years, 9 months ago (2011-03-29 21:36:42 UTC) #2
James Hawkins
http://codereview.chromium.org/6775005/diff/1/chrome/browser/autofill/autofill_download.cc File chrome/browser/autofill/autofill_download.cc (right): http://codereview.chromium.org/6775005/diff/1/chrome/browser/autofill/autofill_download.cc#newcode23 chrome/browser/autofill/autofill_download.cc:23: #include "third_party/libjingle/source/talk/xmllite/xmlparser.h" On 2011/03/29 21:36:42, dhollowa wrote: > Strange ...
9 years, 9 months ago (2011-03-29 22:42:06 UTC) #3
dhollowa
9 years, 9 months ago (2011-03-29 23:08:51 UTC) #4
LGTM pending trys.

Powered by Google App Engine
This is Rietveld 408576698