SettingsWebUITest.TestSetBooleanPrefTriggers fails on Mac

SettingsWebUITest.TestSetBooleanPrefTriggers fails on Mac

Disables failing test on Mac.

BUG=77764
TEST=SettingsWebUITest.TestSetBooleanPrefTriggers
TBR=jstritar@chromium.org, jam@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79689

[jstritar, 2011-03-29 16:13:18]

lgtm

[dtseng, 2011-03-29 20:16:00]

Any idea when this started to fail?



On 3/29/11, dhollowa@chromium.org <dhollowa@chromium.org> wrote:
> Reviewers: jstritar, John Abd-El-Malek,
>
> Description:
> SettingsWebUITest.TestSetBooleanPrefTriggers fails on Mac
>
> Disables failing test on Mac.
>
> BUG=77764
> TEST=SettingsWebUITest.TestSetBooleanPrefTriggers
> TBR=jstritar@chromium.org, jam@chromium.org
>
>
> Please review this at http://codereview.chromium.org/6773010/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>    M chrome/browser/ui/webui/settings_browsertest.cc
>
>
> Index: chrome/browser/ui/webui/settings_browsertest.cc
> diff --git a/chrome/browser/ui/webui/settings_browsertest.cc
> b/chrome/browser/ui/webui/settings_browsertest.cc
> index
>
06019b3121105a0c1ae3bed5e92199f731ae8c89..1cc736d74ffc962bfbe56cf6c17d6ee835490fef
>
> 100644
> --- a/chrome/browser/ui/webui/settings_browsertest.cc
> +++ b/chrome/browser/ui/webui/settings_browsertest.cc
> @@ -73,10 +73,16 @@ class SettingsWebUITest : public WebUIBrowserTest {
>     StrictMock<MockCoreOptionsHandler> mock_core_options_handler_;
>   };
>
> +// Crashes on Mac only.  http://crbug.com/77764
> +#if defined(OS_MACOSX)
> +#define MAYBE_TestSetBooleanPrefTriggers
> DISABLED_TestSetBooleanPrefTriggers
> +#else
> +#define MAYBE_TestSetBooleanPrefTriggers TestSetBooleanPrefTriggers
> +#endif
>   // Test the end to end js to WebUI handler code path for
>   // the message setBooleanPref.
>   // TODO(dtseng): add more EXPECT_CALL's when updating js test.
> -IN_PROC_BROWSER_TEST_F(SettingsWebUITest, TestSetBooleanPrefTriggers) {
> +IN_PROC_BROWSER_TEST_F(SettingsWebUITest,
> MAYBE_TestSetBooleanPrefTriggers) {
>     // This serves as an example of a very constrained test.
>     ListValue true_list_value;
>
> true_list_value.Append(Value::CreateStringValue("browser.show_home_button"));
>
>
>

[jstritar, 2011-03-29 20:27:34]

Roughly around http://crrev.com/79659 and http://crrev.com/79658. There's a
little more info in the bug http://crbug.com/77764.

On Tue, Mar 29, 2011 at 4:15 PM, David Tseng <dtseng@google.com> wrote:

> Any idea when this started to fail?
>
>
>
> On 3/29/11, dhollowa@chromium.org <dhollowa@chromium.org> wrote:
> > Reviewers: jstritar, John Abd-El-Malek,
> >
> > Description:
> > SettingsWebUITest.TestSetBooleanPrefTriggers fails on Mac
> >
> > Disables failing test on Mac.
> >
> > BUG=77764
> > TEST=SettingsWebUITest.TestSetBooleanPrefTriggers
> > TBR=jstritar@chromium.org, jam@chromium.org
> >
> >
> > Please review this at http://codereview.chromium.org/6773010/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> >    M chrome/browser/ui/webui/settings_browsertest.cc
> >
> >
> > Index: chrome/browser/ui/webui/settings_browsertest.cc
> > diff --git a/chrome/browser/ui/webui/settings_browsertest.cc
> > b/chrome/browser/ui/webui/settings_browsertest.cc
> > index
> >
>
06019b3121105a0c1ae3bed5e92199f731ae8c89..1cc736d74ffc962bfbe56cf6c17d6ee835490fef
> >
> > 100644
> > --- a/chrome/browser/ui/webui/settings_browsertest.cc
> > +++ b/chrome/browser/ui/webui/settings_browsertest.cc
> > @@ -73,10 +73,16 @@ class SettingsWebUITest : public WebUIBrowserTest {
> >     StrictMock<MockCoreOptionsHandler> mock_core_options_handler_;
> >   };
> >
> > +// Crashes on Mac only.  http://crbug.com/77764
> > +#if defined(OS_MACOSX)
> > +#define MAYBE_TestSetBooleanPrefTriggers
> > DISABLED_TestSetBooleanPrefTriggers
> > +#else
> > +#define MAYBE_TestSetBooleanPrefTriggers TestSetBooleanPrefTriggers
> > +#endif
> >   // Test the end to end js to WebUI handler code path for
> >   // the message setBooleanPref.
> >   // TODO(dtseng): add more EXPECT_CALL's when updating js test.
> > -IN_PROC_BROWSER_TEST_F(SettingsWebUITest, TestSetBooleanPrefTriggers) {
> > +IN_PROC_BROWSER_TEST_F(SettingsWebUITest,
> > MAYBE_TestSetBooleanPrefTriggers) {
> >     // This serves as an example of a very constrained test.
> >     ListValue true_list_value;
> >
> >
> true_list_value.Append(Value::CreateStringValue("browser.show_home_button"));
> >
> >
> >
>