Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 6773009: PreParser build fix (Closed)

Created:
9 years, 9 months ago by Peter Varga
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

PreParser build fix Patch from Peter Varga <pvarga@inf.u-szeged.hu>;. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/v8-preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Varga
I get the following build error since the preparser got into SConscript/SConstruct (http://codereview.chromium.org/6772002): g++ -o ...
9 years, 9 months ago (2011-03-29 15:30:41 UTC) #1
Lasse Reichstein
Thank you for the patch. The scanner_constants bug has (just) been fixed in revision 7420. ...
9 years, 9 months ago (2011-03-30 08:23:22 UTC) #2
Peter Varga
Should I upload another patch?
9 years, 8 months ago (2011-03-30 10:05:32 UTC) #3
Lasse Reichstein
9 years, 8 months ago (2011-03-30 10:18:11 UTC) #4
Thanks, bu no need, it's a small change.
I've committed.
Thanks for the patch (and for finding the bug!).

Powered by Google App Engine
This is Rietveld 408576698