Add enableReferrers and enableHyperlinkAuditing to contentSettings.misc API.

chrome/browser/profiles/profile_io_data.h

Index: chrome/browser/profiles/profile_io_data.h
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index bb1e049bc83159c91f6742b00dc882099c4e3cba..34d2f2054d98f232969078e127f41dfa82599f76 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -34,6 +34,7 @@ class ProxyService;
 class SSLConfigService;
 class TransportSecurityState;
 }  // namespace net
+template<class T> class PrefMember;
 namespace prerender {
 class PrerenderManager;
 };  // namespace prerender
@@ -42,6 +43,8 @@ namespace webkit_database {
 class DatabaseTracker;
 }  // webkit_database
 
+typedef PrefMember<bool> BooleanPrefMember;
+
 // Conceptually speaking, the ProfileIOData represents data that lives on the IO
 // thread that is owned by a Profile, such as, but not limited to, network
 // objects like CookieMonster, HttpTransactionFactory, etc. The Profile
@@ -116,7 +119,7 @@ class ProfileIOData : public base::RefCountedThreadSafe<ProfileIOData> {
     ProfileId profile_id;
   };
 
-  explicit ProfileIOData(bool is_incognito);
+  explicit ProfileIOData(Profile* profile, bool is_incognito);

[willchan no longer on Chromium, 2011/04/12 16:34:18]

Not explicit anymore.

I have to say, I resisted adding Profile for a long time. The reason is because
ProfileIOData will live on the IO thread. We really don't want to cache the
|profile| pointer, because any use on the IO thread is a bug.

I've been trying to pass the explicit dependency (the initialized
BooleanPrefMember in this case), although I acknowledge that would introduce a
bit of code redundancy. I'm also worried about the ProfileIOData subclasses
caching Profile*. I'm not sure how draconian I should be. I guess I'd be fine
with it if there were comments in the constructors indicating not to cache the
Profile*.

[Bernhard Bauer, 2011/04/12 20:26:05]

Hmm, I could initialize the BooleanPrefMember in the ::Handle constructor,
right? There we already have the Profile, and I could even extract a static
helper method similar to InitializeProfileParams() that does the intialization.

[willchan no longer on Chromium, 2011/04/12 22:43:07]

Yes, I would be fine with that. That's what I referred to in causing code
redundancy, since It'd have to be done for both ProfileImplIOData::Handle and
OffTheRecordProfileIOData::Handle.

[Bernhard Bauer, 2011/04/13 11:17:20]

OK, done (in ChromeNetworkDelegate now, so it can be used by IOThread as well).

   virtual ~ProfileIOData();
 
   // Static helper functions to assist in common operations executed by
@@ -132,6 +135,7 @@ class ProfileIOData : public base::RefCountedThreadSafe<ProfileIOData> {
   // functions have been provided to assist in common operations.
   void LazyInitialize() const;
 
+ protected:

[willchan no longer on Chromium, 2011/04/12 16:34:18]

Look at line 73, there's already a protected section. Actually, everything below
should be private. Other than the new member functions you've added.

[Bernhard Bauer, 2011/04/13 11:17:20]

Oops, done.

   // --------------------------------------------
   // Virtual interface for subtypes to implement:
   // --------------------------------------------
@@ -159,6 +163,15 @@ class ProfileIOData : public base::RefCountedThreadSafe<ProfileIOData> {
           scoped_refptr<ChromeURLRequestContext> main_context,
           const std::string& app_id) const = 0;
 
+  // Called when the profile is destroyed.
+  void Shutdown();

[willchan no longer on Chromium, 2011/04/12 16:34:18]

ShutdownOnUI()

[Bernhard Bauer, 2011/04/13 11:17:20]

Done.

+
+  BooleanPrefMember* enable_referrers() const {
+    return enable_referrers_.get();
+  }
+
+ private:
+  scoped_ptr<BooleanPrefMember> enable_referrers_;

[willchan no longer on Chromium, 2011/04/12 16:34:18]

Why use a pointer? Can't we just directly embed the BooleanPrefMember and
construct it in the initializer list?

[Bernhard Bauer, 2011/04/13 11:17:20]

Very nice! Done.

   mutable bool initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);