Add enableReferrers and enableHyperlinkAuditing to contentSettings.misc API.

chrome/browser/net/chrome_network_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_CHROME_NETWORK_DELEGATE_H_
 #define CHROME_BROWSER_NET_CHROME_NETWORK_DELEGATE_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/prefs/pref_member.h"
 #include "chrome/browser/profiles/profile.h"
 #include "net/base/network_delegate.h"
 
 class ExtensionEventRouterForwarder;
 class ProtocolHandlerRegistry;
 
 // ChromeNetworkDelegate is the central point from within the chrome code to
 // add hooks into the network stack.
 class ChromeNetworkDelegate : public net::NetworkDelegate {
  public:
   // If |profile_id| is the invalid profile, events will be broadcasted to all
   // profiles, otherwise, they will only be sent to the specified profile.
+  // |enable_referrers| is a PrefMember which should be bound to the profile's
+  // PrefService and moved to the IO thread. It can be NULL. This object will

[willchan no longer on Chromium, 2011/04/05 13:10:41]

Why are you allowing it to be NULL? Does it crash otherwise in tests? If
possible, it'd be nice if it were always non-NULL and you added a DCHECK to
enforce this. It makes new readers of the code have to think less and avoids
having to do NULL checks everywhere.

OIC why, it looks like you are passing in NULL for the system
ChromeNetworkDelegate. Is that really what you want to do? Should we be setting
the referer for system requests if an extension disables them?

[Bernhard Bauer, 2011/04/05 14:49:02]

Yeah, I thought about adding support for the pref in the system network delegate
as well, I just decided against doing it right now, as the preference is not
registered in Local State, and there is no client which would set it either. If
you think it's worthwhile though, I can re-add it.

It's also somewhat unlikely that not stripping the referrer from system requests
is going to leak information, as the referrers would probably have to be
explicitly specified anyway.

[willchan no longer on Chromium, 2011/04/05 15:06:18]

I think I'd prefer this, but I don't feel too strongly. I mostly like avoiding
NULL checks where possible since people often forget when they are necessary.
Heh, you never know :) What if we have a DomUI page for configuring system
settings (profile-agnostic), and it uses XHR? That would probably be a
non-profile associated URLRequestContext that might have a referrer.

[Bernhard Bauer, 2011/04/05 16:12:59]

Fair enough. Done.

+  // take ownership of it.
   explicit ChromeNetworkDelegate(
       ExtensionEventRouterForwarder* event_router,
       ProfileId profile_id,
+      BooleanPrefMember* enable_referrers,
       ProtocolHandlerRegistry* protocol_handler_registry);
   virtual ~ChromeNetworkDelegate();
 
  private:
   // NetworkDelegate methods:
   virtual int OnBeforeURLRequest(net::URLRequest* request,
                                  net::CompletionCallback* callback);
   virtual int OnBeforeSendHeaders(uint64 request_id,
                                   net::HttpRequestHeaders* headers,
                                   net::CompletionCallback* callback);
   virtual void OnResponseStarted(net::URLRequest* request);
   virtual void OnReadCompleted(net::URLRequest* request, int bytes_read);
   virtual void OnURLRequestDestroyed(net::URLRequest* request);
   virtual net::URLRequestJob* OnMaybeCreateURLRequestJob(
       net::URLRequest* request);
 
   scoped_refptr<ExtensionEventRouterForwarder> event_router_;
   const ProfileId profile_id_;
+  scoped_ptr<BooleanPrefMember> enable_referrers_;
   scoped_refptr<ProtocolHandlerRegistry> protocol_handler_registry_;
   DISALLOW_COPY_AND_ASSIGN(ChromeNetworkDelegate);
 };
 
 #endif  // CHROME_BROWSER_NET_CHROME_NETWORK_DELEGATE_H_