Make <all_urls> and file:///* in permissions trigger "Allow file access"

chrome/browser/extensions/extension_ui_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "chrome/browser/extensions/extensions_ui.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/json_value_serializer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
   static DictionaryValue* DeserializeJSONTestData(const FilePath& path,
       std::string *error) {
     Value* value;
 
     JSONFileValueSerializer serializer(path);
     value = serializer.Deserialize(NULL, error);
 
     return static_cast<DictionaryValue*>(value);
   }
 
-  static bool CompareExpectedAndActualOutput(
+  static void CheckExpectedAndActualOutput(
       const FilePath& extension_path,
       const std::vector<ExtensionPage>& pages,
       const FilePath& expected_output_path) {
     // TODO(rafaelw): Using the extension_path passed in above, causes this
     // unit test to fail on linux. The Values come back valid, but the
     // UserScript.path() values return "".
 #if defined(OS_WIN)
     FilePath path(FILE_PATH_LITERAL("c:\\foo"));
 #elif defined(OS_POSIX)
     FilePath path(FILE_PATH_LITERAL("/foo"));
@@ skipping 14 matching lines @@
 
     scoped_ptr<DictionaryValue> expected_output_data(DeserializeJSONTestData(
         expected_output_path, &error));
     EXPECT_EQ("", error);
 
     // Produce test output.
     scoped_ptr<DictionaryValue> actual_output_data(
         ExtensionsDOMHandler::CreateExtensionDetailValue(NULL, extension.get(),
                                                          pages, true, false));
 
-    // Compare the outputs.
-    return expected_output_data->Equals(actual_output_data.get());
+    // If the comparison fails, it's easiest to understand why when comparing
+    // the JSON serializations.
+    std::string details = "Expected (" +
+        expected_output_path.MaybeAsASCII() + "):\n";
+    std::string serialization = "";
+    JSONStringValueSerializer serializer(&serialization);
+    serializer.set_pretty_print(true);
+    serializer.Serialize(*expected_output_data);
+    details += serialization;
+
+    details += "\nActual (" + extension_path.MaybeAsASCII() + "):\n";
+    serialization.clear();
+    serializer.Serialize(*actual_output_data);
+    details += serialization;
+
+    EXPECT_TRUE(expected_output_data->Equals(actual_output_data.get()))
+        << details;
   }
 }  // namespace
 
 TEST(ExtensionUITest, GenerateExtensionsJSONData) {
   FilePath data_test_dir_path, extension_path, expected_output_path;
   EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_test_dir_path));
 
   // Test Extension1
   extension_path = data_test_dir_path.AppendASCII("extensions")
       .AppendASCII("good")
       .AppendASCII("Extensions")
       .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
       .AppendASCII("1.0.0.0");
 
   std::vector<ExtensionPage> pages;
   pages.push_back(ExtensionPage(
       GURL("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/bar.html"),
       42, 88, false));
   pages.push_back(ExtensionPage(
       GURL("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/dog.html"),
       0, 0, false));
 
   expected_output_path = data_test_dir_path.AppendASCII("extensions")
       .AppendASCII("ui")
       .AppendASCII("create_extension_detail_value_expected_output")
       .AppendASCII("good-extension1.json");
 
-  EXPECT_TRUE(CompareExpectedAndActualOutput(extension_path, pages,
-      expected_output_path)) << extension_path.value();
+  CheckExpectedAndActualOutput(extension_path, pages, expected_output_path);
 
 #if !defined(OS_CHROMEOS)
   // Test Extension2
   extension_path = data_test_dir_path.AppendASCII("extensions")
       .AppendASCII("good")
       .AppendASCII("Extensions")
       .AppendASCII("hpiknbiabeeppbpihjehijgoemciehgk")
       .AppendASCII("2");
 
   expected_output_path = data_test_dir_path.AppendASCII("extensions")
       .AppendASCII("ui")
       .AppendASCII("create_extension_detail_value_expected_output")
       .AppendASCII("good-extension2.json");
 
   // It's OK to have duplicate URLs, so long as the IDs are different.
   pages[1].url = pages[0].url;
 
-  EXPECT_TRUE(CompareExpectedAndActualOutput(extension_path, pages,
-      expected_output_path)) << extension_path.value();
+  CheckExpectedAndActualOutput(extension_path, pages, expected_output_path);
 #endif
 
   // Test Extension3
   extension_path = data_test_dir_path.AppendASCII("extensions")
       .AppendASCII("good")
       .AppendASCII("Extensions")
       .AppendASCII("bjafgdebaacbbbecmhlhpofkepfkgcpa")
       .AppendASCII("1.0");
 
   expected_output_path = data_test_dir_path.AppendASCII("extensions")
       .AppendASCII("ui")
       .AppendASCII("create_extension_detail_value_expected_output")
       .AppendASCII("good-extension3.json");
 
   pages.clear();
 
-  EXPECT_TRUE(CompareExpectedAndActualOutput(extension_path, pages,
-      expected_output_path)) << extension_path.value();
+  CheckExpectedAndActualOutput(extension_path, pages, expected_output_path);
 }