Make <all_urls> and file:///* in permissions trigger "Allow file access"

chrome/browser/extensions/extensions_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extensions_ui.h"
 
 #include <algorithm>
 
 #include "base/base64.h"
 #include "base/callback.h"
@@ skipping 697 matching lines @@
       url_patterns.begin();
     url_pattern != url_patterns.end(); ++url_pattern) {
     url_pattern_list->Append(new StringValue(url_pattern->GetAsString()));
   }
 
   script_data->Set("matches", url_pattern_list);
 
   return script_data;
 }
 
-static bool ExtensionWantsFileAccess(const Extension* extension) {
-  for (UserScriptList::const_iterator it = extension->content_scripts().begin();
-       it != extension->content_scripts().end(); ++it) {
-    for (UserScript::PatternList::const_iterator pattern =
-             it->url_patterns().begin();
-         pattern != it->url_patterns().end(); ++pattern) {
-      if (pattern->MatchesScheme(chrome::kFileScheme))
-        return true;
-    }
-  }
-
-  return false;
-}
-
 // Static
 DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue(
     ExtensionService* service, const Extension* extension,
     const std::vector<ExtensionPage>& pages, bool enabled, bool terminated) {
   DictionaryValue* extension_data = new DictionaryValue();
   GURL icon =
       ExtensionIconSource::GetIconURL(extension,
                                       Extension::EXTENSION_ICON_MEDIUM,
                                       ExtensionIconSet::MATCH_BIGGER,
                                       !enabled);
   extension_data->SetString("id", extension->id());
   extension_data->SetString("name", extension->name());
   extension_data->SetString("description", extension->description());
   if (extension->location() == Extension::LOAD)
     extension_data->SetString("path", extension->path().value());
   extension_data->SetString("version", extension->version()->GetString());
   extension_data->SetString("icon", icon.spec());
   extension_data->SetBoolean("isUnpacked",
                              extension->location() == Extension::LOAD);
   extension_data->SetBoolean("mayDisable",
                              Extension::UserMayDisable(extension->location()));
   extension_data->SetBoolean("enabled", enabled);
   extension_data->SetBoolean("terminated", terminated);
   extension_data->SetBoolean("enabledIncognito",
       service ? service->IsIncognitoEnabled(extension) : false);
-  extension_data->SetBoolean("wantsFileAccess",
-      ExtensionWantsFileAccess(extension));
+  extension_data->SetBoolean("wantsFileAccess", extension->wants_file_access());
   extension_data->SetBoolean("allowFileAccess",
       service ? service->AllowFileAccess(extension) : false);
   extension_data->SetBoolean("allow_reload",
                              extension->location() == Extension::LOAD);
   extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app());
 
   // Determine the sort order: Extensions loaded through --load-extensions show
   // up at the top. Disabled extensions show up at the bottom.
   if (extension->location() == Extension::LOAD)
     extension_data->SetInteger("order", 1);
@@ skipping 139 matching lines @@
 // static
 RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes() {
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytes(IDR_PLUGIN);
 }
 
 // static
 void ExtensionsUI::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode, false);
 }