Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 6772019: [cros] Change Store/RetrievePolicy to use a GArray (Closed)

Created:
9 years, 9 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-os-reviews_chromium.org, DaveMoore
Visibility:
Public.

Description

[cros] Change Store/RetrievePolicy to use a GArray It seems that sending protobufs as 'strings' works fine with the C dbus-glib bindings, but not with the dbus-python bindings. The signatures of these DBus methods has changed, so change libcros to keep pace. BUG=13249 TEST=manual, using login_drive Change-Id: Id00a2c8c1c5537bf0afbc5a3eeafb38ef1f3ac06 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fb885f0

Patch Set 1 #

Total comments: 4

Patch Set 2 : DCHECK and delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chromeos_cros_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos_login.cc View 1 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Masone
Nothing uses Store/RetrivePolicy yet, so I feel OK changing the signature at this point.
9 years, 9 months ago (2011-03-29 22:43:07 UTC) #1
stevenjb
LGTM with nits http://codereview.chromium.org/6772019/diff/1/chromeos_login.cc File chromeos_login.cc (right): http://codereview.chromium.org/6772019/diff/1/chromeos_login.cc#newcode528 chromeos_login.cc:528: DCHECK(delegate); nit: DCHECK(prop) http://codereview.chromium.org/6772019/diff/1/chromeos_login.cc#newcode534 chromeos_login.cc:534: //g_array_append_vals(policy, ...
9 years, 8 months ago (2011-03-30 14:27:11 UTC) #2
Chris Masone
9 years, 8 months ago (2011-03-30 16:43:29 UTC) #3
http://codereview.chromium.org/6772019/diff/1/chromeos_login.cc
File chromeos_login.cc (right):

http://codereview.chromium.org/6772019/diff/1/chromeos_login.cc#newcode528
chromeos_login.cc:528: DCHECK(delegate);
On 2011/03/30 14:27:11, Steven Bennetts wrote:
> nit: DCHECK(prop)

Done.

http://codereview.chromium.org/6772019/diff/1/chromeos_login.cc#newcode534
chromeos_login.cc:534: //g_array_append_vals(policy, prop, strlen(prop));
On 2011/03/30 14:27:11, Steven Bennetts wrote:
> Delete, or comment if you want to keep this for reference.

Done.

Powered by Google App Engine
This is Rietveld 408576698