Never use classic code generator.

Never use classic code generator.

Crankshaft is now the default on all platforms. This is the first
patch on the way to removing the classic code generator from the
system.

R=kmillikin@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=7469

[Kevin Millikin (Chromium), 2011-04-01 09:45:43]

LGTM.

http://codereview.chromium.org/6771045/diff/2001/src/compiler.cc
File src/compiler.cc (right):

http://codereview.chromium.org/6771045/diff/2001/src/compiler.cc#newcode700
src/compiler.cc:700: if (FLAG_lazy && allow_lazy) {
I think this whole conditional could be simpler:

if (FLAG_lazy && allow_lazy) {
  Handle<Code> code = info.isolate()->builtins()->LazyCompile();
  info.SetCode(code);
} else if ((V8::UseCrankshaft() && MakeCrankshaftCode(&info)) ||
           (!V8::UseCrankshaft() && FullCodeGenerator::MakeCode(&info))) {
  ASSERT(!info.code().is_null());
  scope_info = SerializedScopeInfo::Create(info.scope());
} else {
  return Handle<SharedFunctionInfo>::null();
}

[Mads Ager (chromium), 2011-04-01 09:54:17]

http://codereview.chromium.org/6771045/diff/2001/src/compiler.cc
File src/compiler.cc (right):

http://codereview.chromium.org/6771045/diff/2001/src/compiler.cc#newcode700
src/compiler.cc:700: if (FLAG_lazy && allow_lazy) {
On 2011/04/01 09:45:43, Kevin Millikin wrote:
> I think this whole conditional could be simpler:
> 
> if (FLAG_lazy && allow_lazy) {
>   Handle<Code> code = info.isolate()->builtins()->LazyCompile();
>   info.SetCode(code);
> } else if ((V8::UseCrankshaft() && MakeCrankshaftCode(&info)) ||
>            (!V8::UseCrankshaft() && FullCodeGenerator::MakeCode(&info))) {
>   ASSERT(!info.code().is_null());
>   scope_info = SerializedScopeInfo::Create(info.scope());
> } else {
>   return Handle<SharedFunctionInfo>::null();
> }

Done.