Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 6771044: Fill in a successful response when no hardware TPM. (Closed)

Created:
9 years, 8 months ago by Tom Wai-Hong Tam
Modified:
9 years, 5 months ago
Reviewers:
rongchang
CC:
chromium-os-reviews_chromium.org, robotboy, dneiss, Olof Johansson, amoljadi, chromeboy, Che-Liang Chiou
Visibility:
Public.

Description

Fill in a successful response when no hardware TPM. Caller functions also check the response value. Since the original value is declared in the stack and uninitialized. If we don't change it, the result is unpredictable. BUG=none TEST=build and run bootstub firmware: U-Boot 2010.09-00080-g4eccccb-dirty (Apr 01 2011 - 15:47:42) Board: Tegra2 chromeos/tegra2/seaboard/stub DRAM: 1 GiB Using default environment In: tegra-kbc Out: lcd Err: lcd Hit any key to stop autoboot: 0 SF: Detected W25Q16B with page size 256, total 2 MiB DEBUG: LoadFirmware started... DEBUG: VbSharedDataInit, 16384 bytes, header 1072 bytes DEBUG: TPM: Startup DEBUG: TPM: command: 0c1 000c 00099 DEBUG: TPM: response: 00 000a 0000 DEBUG: TPM: command 0x99 returned 0x0 DEBUG: TPM: Continue self test DEBUG: TPM: command: 0c1 000a 00053 DEBUG: TPM: response: 00 000a 0000 DEBUG: TPM: command 0x53 returned 0x0 DEBUG: Checking key block signature... DEBUG: Firmware 0 is valid. DEBUG: VbSharedDataReserve 1032 bytes at 1072 DEBUG: Checking key block signature... DEBUG: TPM: command: 0c1 00022 00014 DEBUG: TPM: response: 00 000a 0000 DEBUG: TPM: command 0x14 returned 0x0 DEBUG: TPM: SetTPMBootModeState boot mode PCR out_digest 281f6b4 281f6b5 281f6b6 281f6b7 DEBUG: Will boot firmware index 0 load_firmware_wrapper: will jump to rewritable firmware 0 ... Change-Id: Ibb785d720c45b37f62395fef446339f7e77ee1d5 R=rongchang@chromium.org BUG= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=664e579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M lib/chromeos/tlcl_stub.c View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Wai-Hong Tam
9 years, 8 months ago (2011-04-01 08:07:16 UTC) #1
rongchang
9 years, 8 months ago (2011-04-01 08:25:06 UTC) #2
On 2011/04/01 08:07:16, Tom Wai-Hong Tam wrote:

LGTM, Thanks!

Powered by Google App Engine
This is Rietveld 408576698