delta_performer.cc - Issue 6771024: AU: Switch to 2048 bit RSA keys; Pad SHA256 hashes appropriately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: delta_performer.cc

Issue 6771024: AU: Switch to 2048 bit RSA keys; Pad SHA256 hashes appropriately. (Closed) Base URL: http://git.chromium.org/git/update_engine.git@master

Patch Set: remove debug log statement Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: delta_performer.cc

diff --git a/delta_performer.cc b/delta_performer.cc

index 1a98102ff36ec4c04d329bd47699c18b1efc5bdd..54a69fb132f234dbb57088df09086ba8b64a4ca8 100644

--- a/delta_performer.cc

+++ b/delta_performer.cc

@@ -601,7 +601,8 @@ bool DeltaPerformer::VerifyPayload(

OmahaHashCalculator signed_hasher;

TEST_AND_RETURN_FALSE(signed_hasher.SetContext(signed_hash_context_));

TEST_AND_RETURN_FALSE(signed_hasher.Finalize());

- const vector<char>& hash_data = signed_hasher.raw_hash();

+ vector<char> hash_data = signed_hasher.raw_hash();

+ PayloadSigner::PadRSA2048SHA256Hash(&hash_data);

TEST_AND_RETURN_FALSE(!hash_data.empty());

TEST_AND_RETURN_FALSE(hash_data == signed_hash_data);

return true;

« no previous file with comments | « no previous file | delta_performer_unittest.cc » ('j') | payload_signer.h » ('J')