Implement CrashUploadListWin to enable chrome://crashes on Windows.

chrome/browser/crash_upload_list.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CRASH_UPLOAD_LIST_H_
 #define CHROME_BROWSER_CRASH_UPLOAD_LIST_H_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "base/time.h"
@@ skipping 14 matching lines @@
   class Delegate {
    public:
     // Invoked when the crash list has been loaded. Will be called on the
     // UI thread.
     virtual void OnCrashListAvailable() = 0;
 
    protected:
     virtual ~Delegate() {}
   };
 
+  // Static factory method that creates the platform-specific implementation
+  // of the crash upload list with the given callback delegate.
+  static CrashUploadList* Create(Delegate* delegate);
+
   // Creates a new crash upload list with the given callback delegate.
   explicit CrashUploadList(Delegate* delegate);
 
   // Starts loading the crash list. OnCrashListAvailable will be called when
   // loading is complete.
   void LoadCrashListAsynchronously();
 
   // Clears the delegate, so that any outstanding asynchronous load will not
   // call the delegate on completion.
   void ClearDelegate();
 
   // Populates |crashes| with the |max_count| most recent uploaded crashes,
   // in reverse chronological order.
   // Must be called only after OnCrashListAvailable has been called.
   void GetUploadedCrashes(unsigned int max_count,
                           std::vector<CrashInfo>* crashes);
 
- private:
-  friend class base::RefCountedThreadSafe<CrashUploadList>;
+ protected:
   virtual ~CrashUploadList();
 
   // Reads the upload log and stores the lines in log_entries_.

[stuartmorgan, 2011/03/30 16:28:10]

s/log_entries_/crashes_/

[Alexei Svitkine (slow), 2011/03/30 18:54:37]

Done.

-  void LoadUploadLog();
+  virtual void LoadCrashList();
+
+  // Returns a reference to the list of log entries.

[stuartmorgan, 2011/03/30 16:28:10]

s/log entries/crashes/

[Alexei Svitkine (slow), 2011/03/30 18:54:37]

Done.

+  std::vector<CrashInfo>& crashes();
+
+ private:
+  friend class base::RefCountedThreadSafe<CrashUploadList>;
+
+  std::vector<CrashInfo> crashes_;
+  Delegate* delegate_;

[stuartmorgan, 2011/03/30 16:28:10]

Variables should be after functions.

[Alexei Svitkine (slow), 2011/03/30 18:54:37]

Done.

+
+  // Calls LoadCrashList() followed by InformDelegateOfCompletion()
+  // asynchronously.

[stuartmorgan, 2011/03/30 16:28:10]

Too much implementation detail for the header; how about something like "Manages
the background thread work for LoadCrashListAsynchronously"?

[Alexei Svitkine (slow), 2011/03/30 18:54:37]

Done.

+  void LoadCrashListAndInformDelegateOfCompletion();
 
   // Calls the delegate's callback method, if there is a delegate.
   void InformDelegateOfCompletion();
 
-  std::vector<std::string> log_entries_;
-  Delegate* delegate_;
-
   DISALLOW_COPY_AND_ASSIGN(CrashUploadList);
 };
 
 #endif  // CHROME_BROWSER_CRASH_UPLOAD_LIST_H_