Issue 6771015: Fixing build on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6771015: Fixing build on Mac (Closed)

Created:
9 years, 9 months ago by Dmitry Lomov

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/preparser-api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov

Build fails for me on Mac OS without internal:: qualification in preparser-api.cc

9 years, 9 months ago (2011-03-29 17:52:51 UTC) #1

Lasse Reichstein

LGTM (and sorry, that was my last-minute-change).

9 years, 9 months ago (2011-03-30 06:58:06 UTC) #2

Lasse Reichstein

9 years, 9 months ago (2011-03-30 06:59:12 UTC) #3

And I'll just land it for you to speed up the fix.