Issue 6771008: Reduce handle usage in type-info.cc PopulateMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6771008: Reduce handle usage in type-info.cc PopulateMap. (Closed)

Created:
9 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Reduce handle usage in type-info.cc PopulateMap. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7444

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add AllocScope #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
	M	src/type-info.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/type-info.cc	View	1	3 chunks	+18 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

9 years, 8 months ago (2011-03-29 14:12:52 UTC) #2

LGTM.

http://codereview.chromium.org/6771008/diff/1/src/type-info.cc
File src/type-info.cc (right):

http://codereview.chromium.org/6771008/diff/1/src/type-info.cc#newcode379
src/type-info.cc:379: 
maybe AssertNoAllocation from here.

Expand Messages | Collapse Messages