Issue 6770009: Remove snapshots-related code that is implemented in DevTools heap profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6770009: Remove snapshots-related code that is implemented in DevTools heap profiler. (Closed)

Created:
9 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove snapshots-related code that is implemented in DevTools heap profiler. Diffs and retaining paths are implemented on JS side. There is no need to maintain native implementation. R=vitalyr@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7412

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -560 lines)			Patch
M	include/v8-profiler.h	View	4 chunks	+0 lines, -38 lines	0 comments	Download
M	src/api.cc	View	4 chunks	+0 lines, -72 lines	0 comments	Download
M	src/profile-generator.h	View	10 chunks	+0 lines, -90 lines	0 comments	Download
M	src/profile-generator.cc	View	8 chunks	+1 line, -222 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	3 chunks	+0 lines, -133 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM! (I hope nobody was using the API.)

Expand Messages | Collapse Messages