Adding 3G wireless modem firmware check in HWID test

client/site_tests/hardware_Components/hardware_Components.py

Index: client/site_tests/hardware_Components/hardware_Components.py
diff --git a/client/site_tests/hardware_Components/hardware_Components.py b/client/site_tests/hardware_Components/hardware_Components.py
old mode 100644
new mode 100755
index 3ec69b8f8300c07062eaff631a69c600297c825c..0dc6cbb59160aa8b9f488df6546daeab4c29417c
--- a/client/site_tests/hardware_Components/hardware_Components.py
+++ b/client/site_tests/hardware_Components/hardware_Components.py
@@ -44,6 +44,7 @@ class hardware_Components(test.test):
         'part_id_wireless',
         'vendor_id_touchpad',
         'version_rw_firmware',
+        'version_3g_firmware',
     ]
     _pci_cids = [
         'part_id_chipset',
@@ -386,6 +387,23 @@ class hardware_Components(test.test):
             return 'A=%d, B=%d' % (versions[0], versions[1])
         return '%d' % (versions[0])
 
+    def get_version_3g_firmware(self):
+        vendor_cmd = ('modem status | grep Manufacturer: | '

[Jason Glasgow, 2011/03/29 18:06:22]

| sed -n -e "/Manufacturer/s/.*Manufacturer: //p"

instead of running grep and sed.

[Jay Kim, 2011/03/29 18:42:17]

According to Jason's advice I replaced grep and sed with sed. The same
modification was made for getting modem info below.

+                      'sed s/.\*"Manufacturer: "//')
+        vendor = utils.system_output(vendor_cmd)
+        modem_cmd = ('modem status | grep Modem: | '

[Hung-Te, 2011/03/29 13:06:37]

How long does it take to execute one "modem status" command call?

Can we just execute it one time, and use python scripts to parse the results?

That can reduce 3 "modem status" calls into only one.

[Jay Kim, 2011/03/29 18:01:39]

I measured the total execution time of this test with time.time(). The delta
time was 1 sec(measured after fresh reboot). Do you think that we should reduce
it under a second?

[Jason Glasgow, 2011/03/29 18:06:22]

If you are willing to use dbus you can get this information directly in a
dictionary.

[Jay Kim, 2011/03/29 18:42:17]

Actually modem status is getting information from dbus-send commands. 

[Hung-Te, 2011/03/30 03:58:59]

 Probing hardware is the most time-consuming stage in factory process, and that
is critical to most partners because they will need to redesign the flow if time
cost changed - see
http://code.google.com/p/chrome-os-partner/issues/detail?id=2505 for example.

 I'd prefer to minimize the time cost as possible as we can.   If there's no
need to retrieve same result for three times, then we should not do it. Python
regex and string operations are also faster than shell execution.

+                     'sed s/.\*"Modem: "//')
+        modem = utils.system_output(modem_cmd)
+        if vendor == 'Samsung' and modem == 'GT-Y3300X':
+            cmd = ("modem status | grep Version: -A 2 | tail -1 | "
+                   "awk '{print $1}'")
+            version = utils.system_output(cmd)
+        elif vendor == 'Qualcomm Incorporated':
+            cmd = ("modem status | awk '/Version: / {print $2}'")
+            version = utils.system_output(cmd)
+        else:
+            version = 'Unknown'
+        return version
 
     def probe_key_recovery(self, part_id):
         current_key = self._gbb.get_recoverykey()