Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 6770001: Adding 3G wireless modem firmware check in HWID test (Closed)

Created:
9 years, 9 months ago by Jay Kim
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Adding 3G wireless modem firmware check in HWID test Change-Id: If1ffbb9597642602f914716d934a241fdbe99709 BUG=chrome-os-partner:2952 TEST=It should pass HWID validation test only when version_3g_firmware matches This change is to detect the firmware version of Samsung Y3300 which supports USB suspend. It can check Qualcomm firmware version, but it may be used optionally. I verified it on DVT2 with the current Y3300(before suspend fix). When we get the final firmware version from Samsung, we need to update component file to check the firmware ID. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=49749f7

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update the method name to get_version_3g_firmware #

Total comments: 7

Patch Set 3 : Replace grep + sed with sed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M client/site_tests/hardware_Components/hardware_Components.py View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jay Kim
http://codereview.chromium.org/6770001/diff/1/client/site_tests/hardware_Components/hardware_Components.py File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/6770001/diff/1/client/site_tests/hardware_Components/hardware_Components.py#newcode390 client/site_tests/hardware_Components/hardware_Components.py:390: def version_3g_firmware(self): It should be get_version_3g_firmware. Will update this ...
9 years, 9 months ago (2011-03-29 05:28:49 UTC) #1
Hung-Te
http://codereview.chromium.org/6770001/diff/3001/client/site_tests/hardware_Components/hardware_Components.py File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/6770001/diff/3001/client/site_tests/hardware_Components/hardware_Components.py#newcode394 client/site_tests/hardware_Components/hardware_Components.py:394: modem_cmd = ('modem status | grep Modem: | ' ...
9 years, 9 months ago (2011-03-29 13:06:37 UTC) #2
Jay Kim
http://codereview.chromium.org/6770001/diff/3001/client/site_tests/hardware_Components/hardware_Components.py File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/6770001/diff/3001/client/site_tests/hardware_Components/hardware_Components.py#newcode394 client/site_tests/hardware_Components/hardware_Components.py:394: modem_cmd = ('modem status | grep Modem: | ' ...
9 years, 9 months ago (2011-03-29 18:01:39 UTC) #3
Jason Glasgow
I'm working on making mm.py a little better structured for use with both ModemManager and ...
9 years, 9 months ago (2011-03-29 18:06:22 UTC) #4
Jay Kim
This change is made for 0.11.241.B, so I'd like to take advantage of the existing ...
9 years, 9 months ago (2011-03-29 18:42:17 UTC) #5
Hung-Te
LGTM for this to be in factory branch 0.11.241.B, but please reduce the time cost ...
9 years, 9 months ago (2011-03-30 03:58:59 UTC) #6
Nick Sanders
lgtm As Hungte says, for TOT getting 'modem status' once and processing the test or ...
9 years, 8 months ago (2011-03-30 09:50:41 UTC) #7
Jason Glasgow
for ToT please use the mm.py. http://codereview.chromium.org/6731056/ has landed.
9 years, 8 months ago (2011-03-30 18:03:04 UTC) #8
Jay Kim
9 years, 8 months ago (2011-03-30 18:06:38 UTC) #9
AIs for ToT integration
- Use Python Regex 
- Use mm.py instead of modem status

Thanks for your comments!

Powered by Google App Engine
This is Rietveld 408576698