Use 1280x1024 resolution when running ChromeOS under qemu.

Use 1280x1024 resolution when running ChromeOS under qemu.

BUG=none
TEST=Run ChromeOS under qemu, the screen should be 1280x1024 not 800x600.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7e0b3d8

[rkc, 2011-03-29 01:57:30]

LGTM

http://codereview.chromium.org/6768009/diff/1/fixup_image_for_qemu.py
File fixup_image_for_qemu.py (right):

http://codereview.chromium.org/6768009/diff/1/fixup_image_for_qemu.py#newcode3
fixup_image_for_qemu.py:3: # Copyright (c) 2010 The Chromium OS Authors. All
rights reserved.
Nit: 2011 now

[zel, 2011-03-29 04:35:21]

LGTM++

[sosa, 2011-03-30 22:50:04]

After this CL graphics performance is terrible (1 frame per every 2 seconds)
with the VM lib (cros_start_vm).  Is there an option I should pass in to VM to
make it faster?

[marcheu, 2011-03-30 22:53:43]

On Wed, Mar 30, 2011 at 15:50, <sosa@chromium.org> wrote:

> After this CL graphics performance is terrible (1 frame per every 2
> seconds)
> with the VM lib (cros_start_vm).  Is there an option I should pass in to VM
> to
> make it faster?
>
>
Is it that slow? It's pretty usable for me with ToT on my desktop z600.

Stéphane

[sosa, 2011-03-30 22:56:49]

It's very slow on my z600 but I think it's maybe the options in the dev scripts.
 Here's what the vm scripts use as a default:

sudo kvm -m 1024 -vga std -net nic,model=virtio -net user,hostfwd=tcp::9222-:22
-hda <img>

[marcheu, 2011-03-30 23:01:07]

On Wed, Mar 30, 2011 at 15:56, <sosa@chromium.org> wrote:

> It's very slow on my z600 but I think it's maybe the options in the dev
> scripts.
>  Here's what the vm scripts use as a default:
>
> sudo kvm -m 1024 -vga std -net nic,model=virtio -net
> user,hostfwd=tcp::9222-:22
> -hda <img>
>
>
> http://codereview.chromium.org/6768009/
>

Are you sure you run it outside the chroot? Otherwise you can't use kernel
acceleration and it's going to be slow no matter what.

Stéphane

[sosa, 2011-03-30 23:03:04]

No we are migrating the scripts to only work inside the chroot.  That
is unfortunate :(

On Wed, Mar 30, 2011 at 4:00 PM, Stéphane Marchesin
<marcheu@chromium.org> wrote:
>
>
> On Wed, Mar 30, 2011 at 15:56, <sosa@chromium.org> wrote:
>>
>> It's very slow on my z600 but I think it's maybe the options in the dev
>> scripts.
>>  Here's what the vm scripts use as a default:
>>
>> sudo kvm -m 1024 -vga std -net nic,model=virtio -net
>> user,hostfwd=tcp::9222-:22
>> -hda <img>
>>
>> http://codereview.chromium.org/6768009/
>
> Are you sure you run it outside the chroot? Otherwise you can't use kernel
> acceleration and it's going to be slow no matter what.
> Stéphane
>

[marcheu, 2011-03-30 23:04:25]

On Wed, Mar 30, 2011 at 16:02, Chris Sosa <sosa@chromium.org> wrote:

> No we are migrating the scripts to only work inside the chroot.  That
> is unfortunate :(
>
>
Well don't do that then, this will make the qemu unusable.

Stéphane

[sosa, 2011-03-30 23:04:52]

+anush

On Wed, Mar 30, 2011 at 4:04 PM, Stéphane Marchesin
<marcheu@chromium.org> wrote:
>
>
> On Wed, Mar 30, 2011 at 16:02, Chris Sosa <sosa@chromium.org> wrote:
>>
>> No we are migrating the scripts to only work inside the chroot.  That
>> is unfortunate :(
>>
>
> Well don't do that then, this will make the qemu unusable.
> Stéphane
>

[rkc, 2011-03-31 00:24:37]

So marchaeu@ and I strace'd KVM inside and outside chroot. Apparently KVM inside
chroot _is loading the KVM kernel driver; the driver just seems to be refusing
to use CPU virtualization.

Ideally this shouldn't be happening, but the problem is within KVM code, not
ours; hence it would make sense if we just ran this outside chroot as an
exceptional case.

The only thing this change did was expose an already existing problem - kvm
didn't work with hardware virt inside chroot earlier either.

On 2011/03/30 23:04:52, sosa wrote:
> +anush
> 
> On Wed, Mar 30, 2011 at 4:04 PM, Stéphane Marchesin
> <mailto:marcheu@chromium.org> wrote:
> >
> >
> > On Wed, Mar 30, 2011 at 16:02, Chris Sosa <mailto:sosa@chromium.org> wrote:
> >>
> >> No we are migrating the scripts to only work inside the chroot. &nbsp;That
> >> is unfortunate :(
> >>
> >
> > Well don't do that then, this will make the qemu unusable.
> > Stéphane
> >

[sosa, 2011-03-31 00:28:00]

That's ok.  I just wasn't aware.  Probably makes sense to drop support
in the chroot for kvm until that bug is addressed i.e. remove qemu-kvm
from hard-host-depends and require that you run vm scripts from
outside the chroot.

On Wed, Mar 30, 2011 at 5:24 PM,  <rkc@chromium.org> wrote:
> So marchaeu@ and I strace'd KVM inside and outside chroot. Apparently KVM
> inside
> chroot _is loading the KVM kernel driver; the driver just seems to be
> refusing
> to use CPU virtualization.
>
> Ideally this shouldn't be happening, but the problem is within KVM code, not
> ours; hence it would make sense if we just ran this outside chroot as an
> exceptional case.
>
> The only thing this change did was expose an already existing problem - kvm
> didn't work with hardware virt inside chroot earlier either.
>
> On 2011/03/30 23:04:52, sosa wrote:
>>
>> +anush
>
>> On Wed, Mar 30, 2011 at 4:04 PM, Stéphane Marchesin
>> <mailto:marcheu@chromium.org> wrote:
>> >
>> >
>> > On Wed, Mar 30, 2011 at 16:02, Chris Sosa <mailto:sosa@chromium.org>
>> > wrote:
>> >>
>> >> No we are migrating the scripts to only work inside the chroot.
>> >> &nbsp;That
>> >> is unfortunate :(
>> >>
>> >
>> > Well don't do that then, this will make the qemu unusable.
>> > Stéphane
>> >
>
>
>
> http://codereview.chromium.org/6768009/
>

[anush, 2011-03-31 00:42:16]

Running some scripts outside and some inside causes a lot of headaches with
maintaining these scripts. Could we look into if this bug is fixed in later
revs or debug what exactly is the bug ? At the least can we file an issue to
track it with the information you have collected so far.


On Wed, Mar 30, 2011 at 5:27 PM, Chris Sosa <sosa@chromium.org> wrote:

> That's ok.  I just wasn't aware.  Probably makes sense to drop support
> in the chroot for kvm until that bug is addressed i.e. remove qemu-kvm
> from hard-host-depends and require that you run vm scripts from
> outside the chroot.
>
> On Wed, Mar 30, 2011 at 5:24 PM,  <rkc@chromium.org> wrote:
> > So marchaeu@ and I strace'd KVM inside and outside chroot. Apparently
> KVM
> > inside
> > chroot _is loading the KVM kernel driver; the driver just seems to be
> > refusing
> > to use CPU virtualization.
> >
> > Ideally this shouldn't be happening, but the problem is within KVM code,
> not
> > ours; hence it would make sense if we just ran this outside chroot as an
> > exceptional case.
> >
> > The only thing this change did was expose an already existing problem -
> kvm
> > didn't work with hardware virt inside chroot earlier either.
> >
> > On 2011/03/30 23:04:52, sosa wrote:
> >>
> >> +anush
> >
> >> On Wed, Mar 30, 2011 at 4:04 PM, Stéphane Marchesin
> >> <mailto:marcheu@chromium.org> wrote:
> >> >
> >> >
> >> > On Wed, Mar 30, 2011 at 16:02, Chris Sosa <mailto:sosa@chromium.org>
> >> > wrote:
> >> >>
> >> >> No we are migrating the scripts to only work inside the chroot.
> >> >> &nbsp;That
> >> >> is unfortunate :(
> >> >>
> >> >
> >> > Well don't do that then, this will make the qemu unusable.
> >> > Stéphane
> >> >
> >
> >
> >
> > http://codereview.chromium.org/6768009/
> >
>