Making license presubmit check more verbose.

Making license presubmit check more verbose.

BUG=None
TEST=None
R=dpranke@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79644

[Dirk Pranke, 2011-03-28 23:45:01]

You can actually get the original regexp from the compiled version from the
pattern field of the compiled re

i.e., re.compile(x).pattern == x

So you can avoid having to keep two variables around, I think.

[Dirk Pranke, 2011-03-28 23:45:24]

On 2011/03/28 23:45:01, dpranke wrote:
> You can actually get the original regexp from the compiled version from the
> pattern field of the compiled re
> 
> i.e., re.compile(x).pattern == x
> 
> So you can avoid having to keep two variables around, I think.

Also, did something go south when you were uploading the patch? side-by-side
diff doesn't work for me.

[bradn, 2011-03-28 23:45:57]

Yes, appengine horked.


On Mon, Mar 28, 2011 at 4:45 PM, <dpranke@chromium.org> wrote:

> On 2011/03/28 23:45:01, dpranke wrote:
>
>> You can actually get the original regexp from the compiled version from
>> the
>> pattern field of the compiled re
>>
>
>  i.e., re.compile(x).pattern == x
>>
>
>  So you can avoid having to keep two variables around, I think.
>>
>
> Also, did something go south when you were uploading the patch?
> side-by-side
> diff doesn't work for me.
>
>
> http://codereview.chromium.org/6768006/
>

[bradn, 2011-03-28 23:56:12]

Still horked.
Changed:
http://codereview.chromium.org/6768006/patch/2003/4004


On Mon, Mar 28, 2011 at 4:45 PM, Bradley Nelson <bradnelson@google.com>wrote:

> Yes, appengine horked.
>
>
> On Mon, Mar 28, 2011 at 4:45 PM, <dpranke@chromium.org> wrote:
>
>> On 2011/03/28 23:45:01, dpranke wrote:
>>
>>> You can actually get the original regexp from the compiled version from
>>> the
>>> pattern field of the compiled re
>>>
>>
>>  i.e., re.compile(x).pattern == x
>>>
>>
>>  So you can avoid having to keep two variables around, I think.
>>>
>>
>> Also, did something go south when you were uploading the patch?
>> side-by-side
>> diff doesn't work for me.
>>
>>
>> http://codereview.chromium.org/6768006/
>>
>
>

[Dirk Pranke, 2011-03-29 01:19:11]

LGTM.