Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11614)

Unified Diff: courgette/memory_allocator.h

Issue 6767003: Using an explicit constructor for courgette:MemoryAllocator is incompatible with the implementati... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/memory_allocator.h
===================================================================
--- courgette/memory_allocator.h (revision 79466)
+++ courgette/memory_allocator.h (working copy)
@@ -181,7 +181,9 @@
MemoryAllocator() _THROW0() {
}
- explicit MemoryAllocator(const MemoryAllocator<T>& other) _THROW0() {
+ // We can't use an explicit constructor here, as dictated by our style guide.
+ // The implementation of basic_string in Visual Studio 2010 prevents this.
+ MemoryAllocator(const MemoryAllocator<T>& other) _THROW0() {
}
template<class OtherT>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698