Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5122)

Unified Diff: chrome/browser/profiles/profile_dependency_manager_unittest.cc

Issue 6766004: Create a ProfileDependencyManager to order ProfileKeyedService destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix improper usage of static_cast<> in existing mac code. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_dependency_manager_unittest.cc
diff --git a/chrome/browser/profiles/profile_dependency_manager_unittest.cc b/chrome/browser/profiles/profile_dependency_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c50de50e4d17de484092361791b65da91a44f5ee
--- /dev/null
+++ b/chrome/browser/profiles/profile_dependency_manager_unittest.cc
@@ -0,0 +1,185 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "chrome/browser/profiles/profile_dependency_manager.h"
+#include "chrome/browser/profiles/profile_keyed_service_factory.h"
+#include "chrome/test/testing_profile.h"
+
+class ProfileDependencyManagerUnittests : public ::testing::Test {
+ protected:
+ virtual ~ProfileDependencyManagerUnittests() {
+ EXPECT_TRUE(dependency_manager_.all_components_.empty());
+ EXPECT_TRUE(dependency_manager_.edges_.empty());
+ EXPECT_TRUE(dependency_manager_.destruction_order_.empty());
+ }
+
+ // To get around class access:
+ void DependOn(ProfileKeyedServiceFactory* child,
+ ProfileKeyedServiceFactory* parent) {
+ child->DependsOn(parent);
+ }
+
+ void CreateAndDestroyTestProfile() {
+ TestingProfile profile;
+ profile.SetProfileDependencyManager(&dependency_manager_);
+ }
+
+ ProfileDependencyManager* manager() { return &dependency_manager_; }
+
+ std::vector<std::string>* shutdown_order() { return &shutdown_order_; }
+
+ private:
+ ProfileDependencyManager dependency_manager_;
+
+ std::vector<std::string> shutdown_order_;
+};
+
+class TestService : public ProfileKeyedServiceFactory {
+ public:
+ TestService(const std::string& name,
+ std::vector<std::string>* fill_on_shutdown,
+ ProfileDependencyManager* manager)
+ : ProfileKeyedServiceFactory(manager),
+ name_(name),
+ fill_on_shutdown_(fill_on_shutdown) {
+ }
+
+ virtual ProfileKeyedService* BuildServiceInstanceFor(
+ Profile* profile) const {
+ ADD_FAILURE() << "This isn't part of the tests!";
+ return NULL;
+ }
+
+ virtual void ProfileShutdown(Profile* profile) {
+ fill_on_shutdown_->push_back(name_);
+ }
+
+ private:
+ const std::string name_;
+ std::vector<std::string>* fill_on_shutdown_;
+};
+
+// Tests that we can deal with a single component.
+TEST_F(ProfileDependencyManagerUnittests, SingleCase) {
+ TestService service("service", shutdown_order(), manager());
+
+ CreateAndDestroyTestProfile();
+
+ ASSERT_EQ(1U, shutdown_order()->size());
+ EXPECT_STREQ("service", (*shutdown_order())[0].c_str());
+}
+
+// Tests that we get a simple one component depends on the other case.
+TEST_F(ProfileDependencyManagerUnittests, SimpleDependency) {
+ TestService parent("parent", shutdown_order(), manager());
+ TestService child("child", shutdown_order(), manager());
+ DependOn(&child, &parent);
+
+ CreateAndDestroyTestProfile();
+
+ ASSERT_EQ(2U, shutdown_order()->size());
+ EXPECT_STREQ("child", (*shutdown_order())[0].c_str());
+ EXPECT_STREQ("parent", (*shutdown_order())[1].c_str());
+}
+
+// Tests two children, one parent
+TEST_F(ProfileDependencyManagerUnittests, TwoChildrenOneParent) {
+ TestService parent("parent", shutdown_order(), manager());
+ TestService child1("child1", shutdown_order(), manager());
+ TestService child2("child2", shutdown_order(), manager());
+ DependOn(&child1, &parent);
+ DependOn(&child2, &parent);
+
+ CreateAndDestroyTestProfile();
+
+ ASSERT_EQ(3U, shutdown_order()->size());
+ EXPECT_STREQ("child2", (*shutdown_order())[0].c_str());
+ EXPECT_STREQ("child1", (*shutdown_order())[1].c_str());
+ EXPECT_STREQ("parent", (*shutdown_order())[2].c_str());
+}
+
+// Tests an M configuration
+TEST_F(ProfileDependencyManagerUnittests, MConfiguration) {
+ TestService parent1("parent1", shutdown_order(), manager());
+ TestService parent2("parent2", shutdown_order(), manager());
+
+ TestService child_of_1("child_of_1", shutdown_order(), manager());
+ DependOn(&child_of_1, &parent1);
+
+ TestService child_of_12("child_of_12", shutdown_order(), manager());
+ DependOn(&child_of_12, &parent1);
+ DependOn(&child_of_12, &parent2);
+
+ TestService child_of_2("child_of_2", shutdown_order(), manager());
+ DependOn(&child_of_2, &parent2);
+
+ CreateAndDestroyTestProfile();
+
+ ASSERT_EQ(5U, shutdown_order()->size());
+ EXPECT_STREQ("child_of_2", (*shutdown_order())[0].c_str());
+ EXPECT_STREQ("child_of_12", (*shutdown_order())[1].c_str());
+ EXPECT_STREQ("child_of_1", (*shutdown_order())[2].c_str());
+ EXPECT_STREQ("parent2", (*shutdown_order())[3].c_str());
+ EXPECT_STREQ("parent1", (*shutdown_order())[4].c_str());
+}
+
+// Tests that it can deal with a simple diamond.
+TEST_F(ProfileDependencyManagerUnittests, DiamondConfiguration) {
+ TestService parent("parent", shutdown_order(), manager());
+
+ TestService middle_row_1("middle_row_1", shutdown_order(), manager());
+ DependOn(&middle_row_1, &parent);
+
+ TestService middle_row_2("middle_row_2", shutdown_order(), manager());
+ DependOn(&middle_row_2, &parent);
+
+ TestService bottom("bottom", shutdown_order(), manager());
+ DependOn(&bottom, &middle_row_1);
+ DependOn(&bottom, &middle_row_2);
+
+ CreateAndDestroyTestProfile();
+
+ ASSERT_EQ(4U, shutdown_order()->size());
+ EXPECT_STREQ("bottom", (*shutdown_order())[0].c_str());
+ EXPECT_STREQ("middle_row_2", (*shutdown_order())[1].c_str());
+ EXPECT_STREQ("middle_row_1", (*shutdown_order())[2].c_str());
+ EXPECT_STREQ("parent", (*shutdown_order())[3].c_str());
+}
+
+// A final test that works with a more complex graph.
+TEST_F(ProfileDependencyManagerUnittests, ComplexGraph) {
+ TestService everything_depends_on_me("everything_depends_on_me",
+ shutdown_order(), manager());
+
+ TestService intermediary_service("intermediary_service",
+ shutdown_order(), manager());
+ DependOn(&intermediary_service, &everything_depends_on_me);
+
+ TestService specialized_service("specialized_service",
+ shutdown_order(), manager());
+ DependOn(&specialized_service, &everything_depends_on_me);
+ DependOn(&specialized_service, &intermediary_service);
+
+ TestService other_root("other_root", shutdown_order(), manager());
+
+ TestService other_intermediary("other_intermediary",
+ shutdown_order(), manager());
+ DependOn(&other_intermediary, &other_root);
+
+ TestService bottom("bottom", shutdown_order(), manager());
+ DependOn(&bottom, &specialized_service);
+ DependOn(&bottom, &other_intermediary);
+
+ CreateAndDestroyTestProfile();
+
+ ASSERT_EQ(6U, shutdown_order()->size());
+ EXPECT_STREQ("bottom", (*shutdown_order())[0].c_str());
+ EXPECT_STREQ("specialized_service", (*shutdown_order())[1].c_str());
+ EXPECT_STREQ("other_intermediary", (*shutdown_order())[2].c_str());
+ EXPECT_STREQ("intermediary_service", (*shutdown_order())[3].c_str());
+ EXPECT_STREQ("other_root", (*shutdown_order())[4].c_str());
+ EXPECT_STREQ("everything_depends_on_me", (*shutdown_order())[5].c_str());
+}
« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698