Replace bools in extension creation with flags.

chrome/browser/sync/util/extensions_activity_monitor_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/util/extensions_activity_monitor.h"
 
 #include "base/file_path.h"
 #include "base/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/values.h"
@@ skipping 55 matching lines @@
   BookmarkAPIEventGenerator() {}
   virtual ~BookmarkAPIEventGenerator() {}
   template <class T>
   void NewEvent(const FilePath::StringType& extension_path,
       T* bookmarks_function, size_t repeats) {
     std::string error;
     DictionaryValue input;
     input.SetString(keys::kVersion, kTestExtensionVersion);
     input.SetString(keys::kName, kTestExtensionName);
     scoped_refptr<Extension> extension(Extension::Create(
-        FilePath(extension_path), Extension::INVALID, input, false, true,
-        &error));
+        FilePath(extension_path), Extension::INVALID, input,
+        Extension::STRICT_ERROR_CHECKS, &error));
     bookmarks_function->set_name(T::function_name());
     base::WaitableEvent done_event(false, false);
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
         new BookmarkAPIEventTask<T>(bookmarks_function, extension,
                                     repeats, &done_event));
     done_event.Wait();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BookmarkAPIEventGenerator);
@@ skipping 37 matching lines @@
 
   MessageLoop* ui_loop() { return ui_thread_.message_loop(); }
 
   static std::string GetExtensionIdForPath(
       const FilePath::StringType& extension_path) {
     std::string error;
     DictionaryValue input;
     input.SetString(keys::kVersion, kTestExtensionVersion);
     input.SetString(keys::kName, kTestExtensionName);
     scoped_refptr<Extension> extension(Extension::Create(
-        FilePath(extension_path), Extension::INVALID, input, false, true,
-        &error));
+        FilePath(extension_path), Extension::INVALID, input,
+        Extension::STRICT_ERROR_CHECKS, &error));
     EXPECT_EQ("", error);
     return extension->id();
   }
  private:
   NotificationService* service_;
   BrowserThread ui_thread_;
 };
 
 TEST_F(ExtensionsActivityMonitorTest, Basic) {
   ExtensionsActivityMonitor* monitor = new ExtensionsActivityMonitor();
@@ skipping 92 matching lines @@
 
   generator.NewEvent<CreateBookmarkFunction>(kTestExtensionPath1,
       new CreateBookmarkFunction(), 3);
   monitor->GetAndClearRecords(&results);
 
   EXPECT_EQ(1U, results.size());
   EXPECT_EQ(3U, results[id1].bookmark_write_count);
 
   ui_loop()->DeleteSoon(FROM_HERE, monitor);
 }