Issue 6765035: More PrefixSet diagnostics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6765035: More PrefixSet diagnostics. (Closed)

Created:
9 years, 8 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
lzheng

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

More PrefixSet diagnostics. Info about where the unsortedness happens. BUG=71832 TEST=I will monitor resulting histograms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79913

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -10 lines)			Patch
M	chrome/browser/safe_browsing/prefix_set.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set.cc	View	1 chunk	+51 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set_unittest.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database.cc	View	2 chunks	+37 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

This was all I could think of adding. I'll go find the bug before checking ...

9 years, 8 months ago (2011-03-30 21:01:19 UTC) #1

lzheng

9 years, 8 months ago (2011-03-30 23:10:38 UTC) #2

LGTM.

Hope this will give some insights.

On 2011/03/30 21:01:19, shess wrote:
> This was all I could think of adding.  I'll go find the bug before checking
in.
> 
> The diagnostic code is now quite a bit bigger than the operative PrefixSet
code.

Expand Messages | Collapse Messages