Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 6765018: Add fbconsole USE flag for framebuffer console support. (Closed)

Created:
9 years, 8 months ago by Tom Wai-Hong Tam
Modified:
9 years, 5 months ago
CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr+crosoverlay_chromium.org, anush
Visibility:
Public.

Description

Add fbconsole USE flag for framebuffer console support. On ARM kernel, framebuffer console is turned off by default. But in recovery and factory shims, we need it to output messages. BUG=chromium-os:13607 TEST=add fbconsole USE flag when emerging kernel in mod_image_for_recovery.sh. Boot to recovery image and see messages showed on framebuffer console. Change-Id: Icbf9e57ba11535320250bfe0d6e5a940da99ea11 R=olofj@chromium.org,rongchang@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=47f2af3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M sys-kernel/chromeos-kernel-next/chromeos-kernel-next-9999.ebuild View 2 chunks +6 lines, -1 line 0 comments Download
A sys-kernel/chromeos-kernel-next/files/fbconsole.config View 1 chunk +1 line, -0 lines 0 comments Download
M sys-kernel/chromeos-kernel/chromeos-kernel-9999.ebuild View 2 chunks +6 lines, -1 line 0 comments Download
A sys-kernel/chromeos-kernel/files/fbconsole.config View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Wai-Hong Tam
9 years, 8 months ago (2011-03-30 02:23:14 UTC) #1
Olof Johansson
Adding Mandeep and Anush since they tend to keep an eye on the ebuild side ...
9 years, 8 months ago (2011-03-30 03:39:54 UTC) #2
Mandeep Singh Baines
What if we just have it always on? What are the downsides: effect on image ...
9 years, 8 months ago (2011-04-01 15:04:51 UTC) #3
Olof Johansson
The current video driver for tegra doesn't allow more than one client (and framebuffer counts ...
9 years, 8 months ago (2011-04-04 17:40:32 UTC) #4
Tom Wai-Hong Tam
Olof are right. In the base ChromeOS image, the framebuffer console is turned off in ...
9 years, 8 months ago (2011-04-06 02:03:58 UTC) #5
Tom Wai-Hong Tam
Hi, could you kindly give me an approval if these ebuilds look good? Thanks.
9 years, 8 months ago (2011-04-25 08:54:09 UTC) #6
Mandeep Singh Baines
9 years, 8 months ago (2011-04-25 14:35:20 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698