Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 6765006: Fix gyp files for d8 console. Include build/gyp in .gitignore. (Closed)

Created:
9 years, 9 months ago by Martin Maly
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix gyp files for d8 console. Include build/gyp in .gitignore. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Martin Maly
Baby stems in gyp. Turns out currently d8 console when built via gyp doesn't run ...
9 years, 9 months ago (2011-03-28 21:29:41 UTC) #1
Søren Thygesen Gjesse
LGTM
9 years, 9 months ago (2011-03-29 08:28:01 UTC) #2
hegers2012
8 years, 7 months ago (2012-05-09 13:03:10 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698