Add better support for getting the path to crosutils.

Add better support for getting the path to crosutils.

Change-Id: I83a56ee38d8d666d3b71b4dc323e26076fab7d96

BUG=chromium-os:13498
TEST=Ran unittests.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0d5e4ae

[petkov, 2011-03-28 20:48:56]

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode329
lib/cros_build_lib.py:329: def GetCrosUtilsPath(from_source=True):
s/from_source/to_src/

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode338
lib/cros_build_lib.py:338: else:
remove?

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode345
lib/cros_build_lib.py:345: # TODO(sosa): Copied from chromite.
what's left to do?

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode352
lib/cros_build_lib.py:352: CROSUTILS_DIRECTORY = GetCrosUtilsPath(True)
you can still keep the constant at the beginning of the file, no?

[sosa, 2011-03-28 20:57:34]

PTAL

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode329
lib/cros_build_lib.py:329: def GetCrosUtilsPath(from_source=True):
renamed to source_path_dir

On 2011/03/28 20:48:56, petkov wrote:
> s/from_source/to_src/
> 
> 

Done.

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode338
lib/cros_build_lib.py:338: else:
On 2011/03/28 20:48:56, petkov wrote:
> remove?

Done.

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode345
lib/cros_build_lib.py:345: # TODO(sosa): Copied from chromite.
On 2011/03/28 20:48:56, petkov wrote:
> what's left to do?

Done.

http://codereview.chromium.org/6765001/diff/1/lib/cros_build_lib.py#newcode352
lib/cros_build_lib.py:352: CROSUTILS_DIRECTORY = GetCrosUtilsPath(True)
I thought so too, but python complains.  It's probably the def order for
globals.

On 2011/03/28 20:48:56, petkov wrote:
> you can still keep the constant at the beginning of the file, no?

[petkov, 2011-03-28 21:15:24]

LGTM

[sosa, 2011-03-28 21:21:39]

PTAL ... sorry I thought as a good precursor I should also add a method for
crosutils/bin

[petkov, 2011-03-28 21:25:09]

LGTM