Issue 6764015: Made test.py not mention the defunct --crankshaft flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6764015: Made test.py not mention the defunct --crankshaft flag. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Made test.py not mention the defunct --crankshaft flag. Cleanup of X64 assembler. Committed: http://code.google.com/p/v8/source/detail?r=7477

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl dcommit #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -249 lines)			Patch
M	src/x64/assembler-x64.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		200 chunks	+0 lines, -226 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/test.py	View		3 chunks	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 8 months ago (2011-04-01 13:04:10 UTC) #2

LGTM.

http://codereview.chromium.org/6764015/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6764015/diff/1/src/x64/lithium-x64.cc#newcode1616
src/x64/lithium-x64.cc:1616: LOperand* xmm_temp = (instr->CanTruncateToInt32())
Extra parentheses.

Expand Messages | Collapse Messages