Print a grit debugging hint to stdout when a parse exception occurs

Print a grit debugging hint to stdout when a parse exception occurs
to help with locating the error in the .grd file.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80470

[Jói, 2011-04-05 15:34:28]

LGTM

[commit-bot: I haz the power, 2011-04-05 16:08:07]

Presubmit check for 6760030-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  tools/grit/grit/grd_reader.py

[Jói, 2011-04-05 16:29:29]

rhashimoto@, please make sure you run your change through the trybots
and that they complete successfully before trying to commit.

Cheers,
Jói


On Tue, Apr 5, 2011 at 12:08 PM,  <commit-bot@chromium.org> wrote:
> Presubmit check for 6760030-1 failed and returned exit status 1.
>
> Running presubmit commit checks ...
>
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
>
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
>
> ** Presubmit Warnings **
> License must match:
> .*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*?
> Use
> of this source code is governed by a BSD-style license that can be\n.*?
> found in
> the LICENSE file\.\n
> Found a bad license header in these files:
>  tools/grit/grit/grd_reader.py
>
>
>
> http://codereview.chromium.org/6760030/
>

[Jói, 2011-04-05 16:31:18]

Actually... the commit queue does this for you before committing.  So
for a simple change like this you are probably OK.  Just fix the
issues the presubmit check reported, upload a new version, and try
committing again.

Cheers,
Jói


2011/4/5 Jói Sigurðsson <joi@chromium.org>:
> rhashimoto@, please make sure you run your change through the trybots
> and that they complete successfully before trying to commit.
>
> Cheers,
> Jói
>
>
> On Tue, Apr 5, 2011 at 12:08 PM,  <commit-bot@chromium.org> wrote:
>> Presubmit check for 6760030-1 failed and returned exit status 1.
>>
>> Running presubmit commit checks ...
>>
>> ** Presubmit Messages **
>> If this change has an associated bug, add BUG=[bug number].
>>
>> If this change requires manual test instructions to QA team, add
>> TEST=[instructions].
>>
>> ** Presubmit Warnings **
>> License must match:
>> .*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*?
>> Use
>> of this source code is governed by a BSD-style license that can be\n.*?
>> found in
>> the LICENSE file\.\n
>> Found a bad license header in these files:
>>  tools/grit/grit/grd_reader.py
>>
>>
>>
>> http://codereview.chromium.org/6760030/
>>
>

[commit-bot: I haz the power, 2011-04-05 17:04:40]

Change committed as 80470

[Jói, 2011-04-05 17:09:27]

Congratulations Roy, on your first change to Chrome.  Now make sure to
be available on the IRC channel or by IM for the next couple of hours,
and check http://build.chromium.org/p/chromium/console occasionally to
make sure your change seems to be building and passing tests OK.  Take
note that your change does not usually get compiled/tested on its own,
it usually gets grouped with others, and different bots on the
waterfall may group different sets of changes.  A nice way to
visualize this is to click the "merge" link at the bottom of the page.

If you have any questions, feel free to check with me on IM, or ask on
the IRC channel.

Cheers,
Jói


On Tue, Apr 5, 2011 at 1:04 PM,  <commit-bot@chromium.org> wrote:
> Change committed as 80470
>
> http://codereview.chromium.org/6760030/
>