GetBatteryInfo() battery automation hook.

GetBatteryInfo() battery automation hook.

Add a GetBatteryInfo() function accessible through PyAuto. GetBatteryInfo provides information on the state of the battery, including whether a battery is present, how much battery is left, and whether it is charging or discharging.


BUG=chromium-os:12524
TEST=testBatteryInfo included. Use python chromeos_basic.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79774

[krisr, 2011-03-29 01:02:01]

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py...
chrome/test/pyautolib/pyauto.py:2388: 
I actually had to look at the device to see how this works, so we may want to
add some comments:

If battery is true and line_power is false then time_left is time until empty.
If battery is true and line_power is true then time_left is time until charged.
If battery is false and line_power it true then I don't know what time_left is
going to be, can we find out?  Looking at a device in this state it says
"Calculating time until full"

[Nirnimesh, 2011-03-29 01:29:38]

http://codereview.chromium.org/6760013/diff/1/chrome/browser/automation/testi...
File chrome/browser/automation/testing_automation_provider_chromeos.cc (right):

http://codereview.chromium.org/6760013/diff/1/chrome/browser/automation/testi...
chrome/browser/automation/testing_automation_provider_chromeos.cc:139:
return_value->SetBoolean("battery", power_library->battery_is_present());
Match the key string with the function name as much as possible
s/battery/battery_is_present/

Repeat below

http://codereview.chromium.org/6760013/diff/1/chrome/test/functional/chromeos...
File chrome/test/functional/chromeos_basic.py (right):

http://codereview.chromium.org/6760013/diff/1/chrome/test/functional/chromeos...
chrome/test/functional/chromeos_basic.py:29: def testBatteryInfo(self):
Please move this test to a new script - chromeos_power.py

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py...
chrome/test/pyautolib/pyauto.py:2382: u'time_left': 29617,   # 0 if the time
left is still being calculated.
Using 0 for 'still being calculated' case is incorrect.

[dtu, 2011-03-29 02:21:22]

http://codereview.chromium.org/6760013/diff/1/chrome/browser/automation/testi...
File chrome/browser/automation/testing_automation_provider_chromeos.cc (right):

http://codereview.chromium.org/6760013/diff/1/chrome/browser/automation/testi...
chrome/browser/automation/testing_automation_provider_chromeos.cc:139:
return_value->SetBoolean("battery", power_library->battery_is_present());
On 2011/03/29 01:29:39, Nirnimesh wrote:
> Match the key string with the function name as much as possible
> s/battery/battery_is_present/
> 
> Repeat below

Done.

http://codereview.chromium.org/6760013/diff/1/chrome/test/functional/chromeos...
File chrome/test/functional/chromeos_basic.py (right):

http://codereview.chromium.org/6760013/diff/1/chrome/test/functional/chromeos...
chrome/test/functional/chromeos_basic.py:29: def testBatteryInfo(self):
On 2011/03/29 01:29:39, Nirnimesh wrote:
> Please move this test to a new script - chromeos_power.py

Done.

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py...
chrome/test/pyautolib/pyauto.py:2382: u'time_left': 29617,   # 0 if the time
left is still being calculated.
On 2011/03/29 01:29:39, Nirnimesh wrote:
> Using 0 for 'still being calculated' case is incorrect.

Done. Key will be absent in the 'still being calculated' case.

http://codereview.chromium.org/6760013/diff/1/chrome/test/pyautolib/pyauto.py...
chrome/test/pyautolib/pyauto.py:2388: 
On 2011/03/29 01:02:01, krisr wrote:
> I actually had to look at the device to see how this works, so we may want to
> add some comments:
> 
> If battery is true and line_power is false then time_left is time until empty.
> If battery is true and line_power is true then time_left is time until
charged.
> If battery is false and line_power it true then I don't know what time_left is
> going to be, can we find out?  Looking at a device in this state it says
> "Calculating time until full"

Comment expanded. I also changed it so fields only exist if they're relevant, so
those fields will be absent if the battery is missing or the time is still being
calculated.

[dennis_jeffrey, 2011-03-29 15:21:31]

LGTM

Two minor nits.

http://codereview.chromium.org/6760013/diff/6008/chrome/test/functional/chrom...
File chrome/test/functional/chromeos_power.py (right):

http://codereview.chromium.org/6760013/diff/6008/chrome/test/functional/chrom...
chrome/test/functional/chromeos_power.py:12: class
ChromeosBasic(pyauto.PyUITest):
Maybe change name of class to "ChromeosPower"?

http://codereview.chromium.org/6760013/diff/6008/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/6760013/diff/6008/chrome/test/pyautolib/pyauto...
chrome/test/pyautolib/pyauto.py:2394: of 'battery_time_to_full' to determine
whether the battery
"of" --> "or"

[Nirnimesh, 2011-03-29 17:30:01]

LGTM