Issue 6760001: Cleanup of FACTORY and HEAP macro usage in code-stubs.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6760001: Cleanup of FACTORY and HEAP macro usage in code-stubs.cc. (Closed)

Created:
9 years, 9 months ago by Peter Varga

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup of FACTORY and HEAP macro usage in code-stubs.cc. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7390

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	src/code-stubs.cc	View		6 chunks	+15 lines, -10 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 9 months ago (2011-03-28 13:18:12 UTC) #2

I'll take care of these comments and land. Thanks.

http://codereview.chromium.org/6760001/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

http://codereview.chromium.org/6760001/diff/1/src/code-stubs.cc#newcode95
src/code-stubs.cc:95: v8::HandleScope scope;
Use the isolate here as well.

http://codereview.chromium.org/6760001/diff/1/src/code-stubs.cc#newcode137
src/code-stubs.cc:137: Heap* heap = Isolate::Current()->heap();
You can get the isolate from the macro assembler.

Expand Messages | Collapse Messages