tests/gclient_utils_test.py - Issue 6759074: Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_utils_test.py

Issue 6759074: Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_utils_test.py

diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py

index b00db3c80e08d4637fc628d85c06719ebdaab897..63369b2dfd2e65ed6944de5506032e69f6dcd713 100755

--- a/tests/gclient_utils_test.py

+++ b/tests/gclient_utils_test.py

@@ -33,8 +33,8 @@ class GclientUtilsUnittest(GclientUtilBase):

'ParseXML', 'Popen',

'PrintableObject', 'RemoveDirectory', 'SoftClone', 'SplitUrlRevision',

'SyntaxErrorToError', 'WorkItem',

- 'errno', 'hack_subprocess', 'logging', 'os', 'Queue', 're', 'rmtree',

- 'stat', 'subprocess', 'sys','threading', 'time', 'xml',

+ 'errno', 'logging', 'os', 'Queue', 're', 'rmtree',

+ 'stat', 'subprocess', 'subprocess2', 'sys','threading', 'time', 'xml',

]

# If this test fails, you should add the relevant test.

self.compareMembers(gclient_utils, members)

« no previous file with comments | « subprocess2.py ('k') | no next file » | no next file with comments »