Issue 6759074: Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6759074: Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead." (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Reapply r79779: "Removed gclient_utils.Popen() and use subprocess2's version instead." It should be fine now that I've fixed python2.5 compatilibity issues in subprocess2.py. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80216

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -38 lines)			Patch
M	gclient_utils.py	View	3 chunks	+3 lines, -33 lines	0 comments	Download
M	subprocess2.py	View	4 chunks	+18 lines, -3 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM.