Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 6759070: Reapply: Never use classic code generator. (Closed)

Created:
9 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reapply: Never use classic code generator. Crankshaft is now the default on all platforms. This is the first patch on the way to removing the classic code generator from the system. This time with no removal of the crankshaft flag. --nocrankshaft is not at all the same as --always-full-compiler which I had used instead for testing. That was what caused timeouts on the buildbots because of repeated attempts to optimize hot functions. It makes sense to keep the crankshaft flag in case you want to run only with the full compiler and with no adaptive compilation. R=vitalyr@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -105 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ast.h View 4 chunks +1 line, -6 lines 0 comments Download
M src/compiler.cc View 4 chunks +8 lines, -53 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/objects.h View 3 chunks +6 lines, -10 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/test.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 8 months ago (2011-04-01 19:42:44 UTC) #1
Mads Ager (chromium)
TBR
9 years, 8 months ago (2011-04-01 19:45:07 UTC) #2
Vitaly Repeshko
9 years, 8 months ago (2011-04-01 20:04:34 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698