[autotest] Update login_OwnershipApi to use protobufs

[autotest] Update login_OwnershipApi to use protobufs

BUG=13652
TEST=run this test

Change-Id: Ib87848224dfd97d10e0a5bd52aaaef8da701d409

R=wad@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bbd576f

[Chris Masone, 2011-04-04 01:54:12]

On 2011/04/01 17:32:51, Chris Masone wrote:

Redirect to petkov

[petkov, 2011-04-04 17:11:53]

http://codereview.chromium.org/6759063/diff/1/client/cros/constants.py
File client/cros/constants.py (right):

http://codereview.chromium.org/6759063/diff/1/client/cros/constants.py#newcode61
client/cros/constants.py:61: SIGNED_POLICY_FILE = WHITELIST_DIR+'/policy'
spaces around + (and above)

http://codereview.chromium.org/6759063/diff/1/client/site_tests/login_Ownersh...
File client/site_tests/login_OwnershipApi/login_OwnershipApi.py (right):

http://codereview.chromium.org/6759063/diff/1/client/site_tests/login_Ownersh...
client/site_tests/login_OwnershipApi/login_OwnershipApi.py:30:
os.chdir(self.srcdir)
Are the "src" contents part of another CL?

[Chris Masone, 2011-04-04 17:33:31]

http://codereview.chromium.org/6759063/diff/1/client/cros/constants.py
File client/cros/constants.py (right):

http://codereview.chromium.org/6759063/diff/1/client/cros/constants.py#newcode61
client/cros/constants.py:61: SIGNED_POLICY_FILE = WHITELIST_DIR+'/policy'
On 2011/04/04 17:11:53, petkov wrote:
> spaces around + (and above)

Done.

http://codereview.chromium.org/6759063/diff/1/client/site_tests/login_Ownersh...
File client/site_tests/login_OwnershipApi/login_OwnershipApi.py (right):

http://codereview.chromium.org/6759063/diff/1/client/site_tests/login_Ownersh...
client/site_tests/login_OwnershipApi/login_OwnershipApi.py:30:
os.chdir(self.srcdir)
On 2011/04/04 17:11:53, petkov wrote:
> Are the "src" contents part of another CL?

whoops.

[petkov, 2011-04-04 17:48:01]

A couple of nits related to make variable management.

LGTM otherwise.

http://codereview.chromium.org/6759063/diff/7001/client/site_tests/login_Owne...
File client/site_tests/login_OwnershipApi/login_OwnershipApi.py (right):

http://codereview.chromium.org/6759063/diff/7001/client/site_tests/login_Owne...
client/site_tests/login_OwnershipApi/login_OwnershipApi.py:31: utils.make()
make variables are usually passed on the command line:

utils.make('OUT_DIR=' + self.srcdir)

(You could actually do 'OUT_DIR=.' given that you're chdir'ing anyway.)

http://codereview.chromium.org/6759063/diff/7001/client/site_tests/login_Owne...
File client/site_tests/login_OwnershipApi/src/Makefile (right):

http://codereview.chromium.org/6759063/diff/7001/client/site_tests/login_Owne...
client/site_tests/login_OwnershipApi/src/Makefile:5: # Requires $(SYSROOT) and
$(OUT_DIR) to be set.
You could:

ifndef SYSROOT
  $(error Define SYSROOT)
endif

Also, you could define a default for OUT_DIR:

OUT_DIR = .

[Chris Masone, 2011-04-04 18:00:02]

http://codereview.chromium.org/6759063/diff/7001/client/site_tests/login_Owne...
File client/site_tests/login_OwnershipApi/src/Makefile (right):

http://codereview.chromium.org/6759063/diff/7001/client/site_tests/login_Owne...
client/site_tests/login_OwnershipApi/src/Makefile:5: # Requires $(SYSROOT) and
$(OUT_DIR) to be set.
On 2011/04/04 17:48:01, petkov wrote:
> You could:
> 
> ifndef SYSROOT
>   $(error Define SYSROOT)
> endif
> 
> Also, you could define a default for OUT_DIR:
> 
> OUT_DIR = .

Done.

[petkov, 2011-04-04 18:02:23]

LGTM

Perfect :-)