Introduce v8::Object::CreationContext method.

Introduce v8::Object::CreationContext method.

That allows to find out a global context in which the object
was created.

Committed: http://code.google.com/p/v8/source/detail?r=7476

[antonm, 2011-04-01 11:11:48]

Mads,

may you have a look?

I used it for my experiments.  But yesterday Aaron (cc'ed) independently showed
an interest in such an API.

[Mads Ager (chromium), 2011-04-01 11:19:38]

LGTM

I think we should add more testing though.

http://codereview.chromium.org/6759054/diff/1004/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/6759054/diff/1004/include/v8.h#newcode1656
include/v8.h:1656: * Returns a context in which the object was created.
a context -> the context

http://codereview.chromium.org/6759054/diff/1004/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6759054/diff/1004/src/api.cc#newcode2882
src/api.cc:2882: static i::Context* creationContext(i::JSObject* object) {
Use Google naming convention please: CreationContext

http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:13634: THREADED_TEST(CreationContext) {
Would be nice to extend this test with stuff created through the API. In
particular, there is an API function path in your code that you do not test.

[antonm, 2011-04-01 12:15:46]

Thanks a lot for review, Mads.  Submitting.

http://codereview.chromium.org/6759054/diff/1004/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/6759054/diff/1004/include/v8.h#newcode1656
include/v8.h:1656: * Returns a context in which the object was created.
On 2011/04/01 11:19:38, Mads Ager wrote:
> a context -> the context

Done.

http://codereview.chromium.org/6759054/diff/1004/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6759054/diff/1004/src/api.cc#newcode2882
src/api.cc:2882: static i::Context* creationContext(i::JSObject* object) {
On 2011/04/01 11:19:38, Mads Ager wrote:
> Use Google naming convention please: CreationContext

Done.

http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:13634: THREADED_TEST(CreationContext) {
On 2011/04/01 11:19:38, Mads Ager wrote:
> Would be nice to extend this test with stuff created through the API. In
> particular, there is an API function path in your code that you do not test.

Done.  I'll add more if you think it's still not enough.