Issue 6759030: Microoptimizations to the way we get the current heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6759030: Microoptimizations to the way we get the current heap. (Closed)

Created:
9 years, 8 months ago by Erik Corry

Modified:
9 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Microoptimizations to the way we get the current heap. Committed: http://code.google.com/p/v8/source/detail?r=7455

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+245 lines, -177 lines)			Patch
M	src/objects.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1	84 chunks	+209 lines, -177 lines	1 comment	Download
M	src/objects-inl.h	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 8 months ago (2011-03-30 15:57:33 UTC) #2

LGTM

http://codereview.chromium.org/6759030/diff/3005/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/6759030/diff/3005/src/objects.cc#newcode116
src/objects.cc:116: HeapObject* heap_this = HeapObject::cast(this);
heap_this is confusing name.

Expand Messages | Collapse Messages