Issue 6759029: Cleanup of Isolate::Current() and FACTORY macro usage in execution.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6759029: Cleanup of Isolate::Current() and FACTORY macro usage in execution.cc. (Closed)

Created:
9 years, 8 months ago by Peter Varga

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup of Isolate::Current() and FACTORY macro usage in execution.cc. BUG=none TEST=none Patch from Peter Varga <pvarga@inf.u-szeged.hu>;. Committed: http://code.google.com/p/v8/source/detail?r=7464

Patch Set 1 #

Total comments: 4

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -28 lines)			Patch
	M	src/execution.cc	View		16 chunks	+43 lines, -28 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 8 months ago (2011-04-01 07:56:18 UTC) #2

Thanks for the patch. I'll take care of these comments and land.

http://codereview.chromium.org/6759029/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/6759029/diff/1/src/execution.cc#newcode556
src/execution.cc:556: Isolate* isolate = Isolate::Current();
Get the isolate from the string instead of going through TLS?

http://codereview.chromium.org/6759029/diff/1/src/execution.cc#newcode588
src/execution.cc:588: Isolate* isolate = Isolate::Current();
Get the isolate from the data instead of going through TLS?

http://codereview.chromium.org/6759029/diff/1/src/execution.cc#newcode607
src/execution.cc:607: Isolate* isolate = Isolate::Current();
Ditto.

http://codereview.chromium.org/6759029/diff/1/src/execution.cc#newcode759
src/execution.cc:759: debug_command_only);
Indentation is off.

Expand Messages | Collapse Messages