Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 6759016: build_image: set verity_depth default to 3 (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
jrbarnette, Will Drewry
CC:
chromium-os-reviews_chromium.org, anush, sosa
Visibility:
Public.

Description

build_image: set verity_depth default to 3 This is in preparation for moving to a level 0 count of 1. Seems to give about 200ms boot speedup. Before(verity_depth = 1): seconds_power_on_to_login 7.73 seconds_power_on_to_login{1} 7.97 seconds_power_on_to_login{2} 7.8 seconds_power_on_to_login{3} 7.86 seconds_power_on_to_login{4} 7.84 seconds_power_on_to_login{5} 7.81 seconds_power_on_to_login{6} 7.85 seconds_power_on_to_login{7} 7.85 seconds_power_on_to_login{8} 7.85 seconds_power_on_to_login{9} 7.82 After(verity_depth = 3) seconds_power_on_to_login 7.57 seconds_power_on_to_login{1} 7.89 seconds_power_on_to_login{2} 7.54 seconds_power_on_to_login{3} 7.56 seconds_power_on_to_login{4} 7.53 seconds_power_on_to_login{5} 7.56 seconds_power_on_to_login{6} 7.79 seconds_power_on_to_login{7} 7.58 seconds_power_on_to_login{8} 7.56 seconds_power_on_to_login{9} 7.62 BUG=chromium-os:9752 TEST=platform_BootPerfServer Change-Id: I7f6e39ad2ed2c2e8ebc463860578c3f97b8295a2 R=wad@chromium.org,jrbarnette@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=63ca269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build_image View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mandeep Singh Baines
9 years, 9 months ago (2011-03-30 01:16:23 UTC) #1
Will Drewry
LGTM It's probably worth creating two images - installing the first via recovery then generating ...
9 years, 9 months ago (2011-03-30 01:19:24 UTC) #2
Mandeep Singh Baines
On 2011/03/30 01:19:24, Will Drewry wrote: > LGTM > > It's probably worth creating two ...
9 years, 9 months ago (2011-03-30 01:28:58 UTC) #3
Will Drewry
9 years, 9 months ago (2011-03-30 01:33:06 UTC) #4
On 2011/03/30 01:28:58, Mandeep Singh Baines wrote:
> On 2011/03/30 01:19:24, Will Drewry wrote:
> > LGTM
> > 
> > It's probably worth creating two images - installing the first via recovery
> then
> > generating an AU payload and upgrading it.  That should exercise all code
> paths
> > that parse/interact with the verity args.
> > 
> 
> I've tested USB install and update_kernel.

Awesome

> Will image_to_live test the AU case?

I think so!

Powered by Google App Engine
This is Rietveld 408576698