Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 6758040: Add new site parser based off on generate_test_report. (Closed)

Created:
9 years, 8 months ago by DaleCurtis
Modified:
9 years, 7 months ago
Reviewers:
pauldean, ericli, Dale Curtis, pauldean
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Add new site parser based off on generate_test_report. This site parser is used to generate a JSON report of test failures, crashes, and the associated logs for later consumption by an Email generator. The parser uses the test report generator which comes bundled with the Chrome OS source tree in order to maintain consistency. As well as not having to keep track of any secondary failure white lists. The path to the Chrome OS source tree is defined in global_config under the CROS section as 'source_tree'. Existing parse behavior is kept completely intact. If the site parser is not configured it will print a debug message and exit after default parser is called. Relies on changes to generate_test_report here: http://codereview.chromium.org/6731024/ Change-Id: Ib4696b88a22ca67b0822a72366d57709a5863ae5 BUG=chromium-os:12100, chromium-os:13586, chromium-os:13496 TEST=Ran parser on many sets of results. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e5436f3

Patch Set 1 #

Total comments: 5

Patch Set 2 : Switch to json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -5 lines) Patch
A scheduler/site_monitor_db.py View 1 chunk +10 lines, -0 lines 0 comments Download
M tko/parsers/version_0.py View 1 chunk +5 lines, -5 lines 0 comments Download
A tko/site_parse View 1 chunk +5 lines, -0 lines 0 comments Download
A tko/site_parse.py View 1 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
9 years, 8 months ago (2011-03-31 19:37:06 UTC) #1
pauldean_chromium
I'm not familiar with the generate_test_report piece that this relies on, so I can't comment ...
9 years, 8 months ago (2011-03-31 20:28:41 UTC) #2
ericli
overall LGTM. http://codereview.chromium.org/6758040/diff/1/tko/parsers/version_0.py File tko/parsers/version_0.py (right): http://codereview.chromium.org/6758040/diff/1/tko/parsers/version_0.py#newcode267 tko/parsers/version_0.py:267: kv = re.search(r"^(\w+)=(.+)", parts[part_index]) dont do this ...
9 years, 8 months ago (2011-03-31 21:04:24 UTC) #3
Dale Curtis
9 years, 8 months ago (2011-03-31 21:09:58 UTC) #4
http://codereview.chromium.org/6758040/diff/1/tko/parsers/version_0.py
File tko/parsers/version_0.py (right):

http://codereview.chromium.org/6758040/diff/1/tko/parsers/version_0.py#newcod...
tko/parsers/version_0.py:267: kv = re.search(r"^(\w+)=(.+)", parts[part_index])
This is a local only change that I made a long time ago. I just realized it had
the wrong identing.

On 2011/03/31 21:04:24, ericli wrote:
> dont do this unless you want to upstream your change. It only give me trouble
at
> merge time but nothing else.

http://codereview.chromium.org/6758040/diff/1/tko/site_parse.py
File tko/site_parse.py (right):

http://codereview.chromium.org/6758040/diff/1/tko/site_parse.py#newcode24
tko/site_parse.py:24: import os, simplejson, sys
On 2011/03/31 21:04:24, ericli wrote:
> we are using json and simple json across the autotest codebase, better use
only
> one.

Done.

Powered by Google App Engine
This is Rietveld 408576698