Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 6758007: Increase coverage of global loads in optimized code (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1716 return DefineAsRegister(new LConstantD); 1716 return DefineAsRegister(new LConstantD);
1717 } else if (r.IsTagged()) { 1717 } else if (r.IsTagged()) {
1718 return DefineAsRegister(new LConstantT); 1718 return DefineAsRegister(new LConstantT);
1719 } else { 1719 } else {
1720 UNREACHABLE(); 1720 UNREACHABLE();
1721 return NULL; 1721 return NULL;
1722 } 1722 }
1723 } 1723 }
1724 1724
1725 1725
1726 LInstruction* LChunkBuilder::DoLoadGlobal(HLoadGlobal* instr) { 1726 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) {
1727 LLoadGlobal* result = new LLoadGlobal(); 1727 LLoadGlobalCell* result = new LLoadGlobalCell();
fschneider 2011/04/01 11:38:57 Should be enough to write: new LLoadGlobalCell;
Søren Thygesen Gjesse 2011/04/01 11:47:32 Done.
1728 return instr->check_hole_value() 1728 return instr->check_hole_value()
1729 ? AssignEnvironment(DefineAsRegister(result)) 1729 ? AssignEnvironment(DefineAsRegister(result))
1730 : DefineAsRegister(result); 1730 : DefineAsRegister(result);
1731 } 1731 }
1732 1732
1733 1733
1734 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
1735 LOperand* global_object = UseFixed(instr->global_object(), r0);
1736 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object);
1737 return MarkAsCall(DefineFixed(result, r0), instr);
1738 }
1739
1740
1734 LInstruction* LChunkBuilder::DoStoreGlobal(HStoreGlobal* instr) { 1741 LInstruction* LChunkBuilder::DoStoreGlobal(HStoreGlobal* instr) {
1735 if (instr->check_hole_value()) { 1742 if (instr->check_hole_value()) {
1736 LOperand* temp = TempRegister(); 1743 LOperand* temp = TempRegister();
1737 LOperand* value = UseRegister(instr->value()); 1744 LOperand* value = UseRegister(instr->value());
1738 return AssignEnvironment(new LStoreGlobal(value, temp)); 1745 return AssignEnvironment(new LStoreGlobal(value, temp));
1739 } else { 1746 } else {
1740 LOperand* value = UseRegisterAtStart(instr->value()); 1747 LOperand* value = UseRegisterAtStart(instr->value());
1741 return new LStoreGlobal(value, NULL); 1748 return new LStoreGlobal(value, NULL);
1742 } 1749 }
1743 } 1750 }
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
2097 2104
2098 2105
2099 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2106 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2100 HEnvironment* outer = current_block_->last_environment()->outer(); 2107 HEnvironment* outer = current_block_->last_environment()->outer();
2101 current_block_->UpdateEnvironment(outer); 2108 current_block_->UpdateEnvironment(outer);
2102 return NULL; 2109 return NULL;
2103 } 2110 }
2104 2111
2105 2112
2106 } } // namespace v8::internal 2113 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698