README.codereview - Issue 6758001: Move git_cl back into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: README.codereview

Issue 6758001: Move git_cl back into depot_tools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Add stub to not break incremental update Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « PRESUBMIT.py ('k') | README.git-cl » ('j') | no next file with comments »

OLD	NEW
1 The git-cl README describes the git-cl command set. This document	1 The git-cl README describes the git-cl command set. This document

2 describes how code review and git work together in general, intended	2 describes how code review and git work together in general, intended

3 for people familiar with git but unfamiliar with the code review	3 for people familiar with git but unfamiliar with the code review

4 process supported by Rietveld.	4 process supported by Rietveld.

5	5

6 == Concepts and terms	6 == Concepts and terms

7 A Rietveld review is for discussion of a single change or patch. You	7 A Rietveld review is for discussion of a single change or patch. You

8 upload a proposed change, the reviewer comments on your change, and	8 upload a proposed change, the reviewer comments on your change, and

9 then you can upload a revised version of your change. Rietveld stores	9 then you can upload a revised version of your change. Rietveld stores

10 the history of uploaded patches as well as the comments, and can	10 the history of uploaded patches as well as the comments, and can

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90	90

91 O---A---B---C	91 O---A---B---C

92 \ \ \	92 \ \ \

93 A'--B'--C'	93 A'--B'--C'

94	94

95 Which is ugly, but it accurately tracks the real history of your work, can	95 Which is ugly, but it accurately tracks the real history of your work, can

96 be thrown away at the end by committing A+A' as a single "squash" commit.	96 be thrown away at the end by committing A+A' as a single "squash" commit.

97	97

98 In practice, this comes up pretty rarely. Suggestions for better workflows	98 In practice, this comes up pretty rarely. Suggestions for better workflows

99 are welcome.	99 are welcome.

OLD	NEW