Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 6758001: Move git_cl back into depot_tools. (Closed)

Created:
9 years, 9 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Evan Martin
Visibility:
Public.

Description

Move git_cl back into depot_tools. Remove git_cl_hooks.py since it's now unnecessary. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79715

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix presubmit check #

Patch Set 3 : Add stub to not break incremental update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2424 lines) Patch
M PRESUBMIT.py View 1 2 chunks +58 lines, -4 lines 0 comments Download
A + README.codereview View 0 chunks +-1 lines, --1 lines 0 comments Download
A + README.git-cl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + README.testing View 0 chunks +-1 lines, --1 lines 0 comments Download
M git-cl View 1 chunk +4 lines, -1 line 0 comments Download
A + git_cl.py View 1 3 chunks +15 lines, -27 lines 0 comments Download
D git_cl/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D git_cl/PRESUBMIT.py View 1 chunk +0 lines, -71 lines 0 comments Download
D git_cl/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D git_cl/git-cl View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
D git_cl/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D git_cl/upload.py View 1 chunk +0 lines, -2210 lines 0 comments Download
D git_cl_hooks.py View 1 chunk +0 lines, -90 lines 0 comments Download
M tests/__init__.py View 1 chunk +0 lines, -6 lines 0 comments Download
A + tests/abandon.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/basic.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/hooks.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/local_rietveld.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/owners.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/patch.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/post-dcommit-hook-test.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/push-basic.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/push-from-logs.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/rename.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/save-description-on-failure.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/submit-from-new-dir.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/tbr.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/test-lib.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/upload-local-tracking-branch.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/upload-stale.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/upstream.sh View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Running presubmit upload checks ... Checking out rietveld... Running patch.sh Running upload-local-tracking-branch.sh Running tbr.sh Running ...
9 years, 9 months ago (2011-03-28 01:00:23 UTC) #1
M-A Ruel
Note that there is a bug in git-cl where it doesn't show the files that ...
9 years, 9 months ago (2011-03-28 01:00:57 UTC) #2
M-A Ruel
On 2011/03/28 01:00:57, Marc-Antoine Ruel wrote: > Note that there is a bug in git-cl ...
9 years, 9 months ago (2011-03-28 01:01:15 UTC) #3
Dirk Pranke
LGTM.
9 years, 9 months ago (2011-03-28 01:09:25 UTC) #4
M-A Ruel
9 years, 9 months ago (2011-03-28 01:24:56 UTC) #5
FTR about the git mv bug, I've described it at
http://code.google.com/p/rietveld/issues/detail?id=285 since it's really a bug
in upload.py due to the way git diff generates the diff.

Powered by Google App Engine
This is Rietveld 408576698