Remove extension automation support that was used only by CEEE.

chrome_frame/chrome_tab.idl

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file will be processed by the MIDL tool to
 // produce the type library (chrome_tab.tlb) and marshalling code.
 
 #include "olectl.h"
 import "oaidl.idl";
 import "ocidl.idl";
 
 [
   object,
-  uuid(FB243E4B-8AC2-4840-95F2-91B9AF9CFF10),
+  uuid(25248626-A306-4857-A13C-4AD84FF15E10),

[amit, 2011/04/05 18:00:24]

Tommi pointed out that any existing users embedding GCF will break with this
change.  Maybe we keep the methods (perhaps rename them) and return E_NOTIMPL?

[Jói, 2011/04/05 18:47:10]

OK, will address this and upload a new version soon.

Just to confirm:  This is only an issue for IE, right?  Just removing the
Firefox methods should be fine, it will generate an error only for those who try
to use them.

[amit, 2011/04/05 18:50:17]

Yes, that's perfect. Also, please double check that the other artifacts like
typelib are still compatible.
Thanks!

[Jói, 2011/04/05 19:24:45]

I reverted the IID change here and on the dispinterface, and left the three
deprecated methods in (they return E_NOTIMPL in chrome_frame_activex_base.h).

   dual,
   nonextensible,
   helpstring("IChromeFrame Interface"),
   pointer_default(unique)
 ]
 interface IChromeFrame : IDispatch {
   [propget, id(1)]
   HRESULT src([out, retval] BSTR* src);
   [propput, id(1)]
   HRESULT src([in] BSTR src);
@@ skipping 34 matching lines @@
   // This method is available only when the control is in privileged mode.
   HRESULT postPrivateMessage([in] BSTR message,
                              [in] BSTR origin,
                              [in] BSTR target);
 
   [propget, id(11)]
   HRESULT useChromeNetwork([out, retval] VARIANT_BOOL* pVal);
   [propput, id(11)]
   HRESULT useChromeNetwork([in] VARIANT_BOOL newVal);
 
-  [id(12), hidden]
-  // This method is available only when the control is in privileged mode.
-  HRESULT installExtension([in] BSTR crx_path);
-
-  [id(13), hidden]
-  // This method is available only when the control is in privileged mode.
-  HRESULT loadExtension([in] BSTR extension_path);
-
-  [id(14), hidden]
-  // This method is available only when the control is in privileged mode.
-  HRESULT getEnabledExtensions();
-
   [id(15)]
   // This method bootstraps the BHO if it is not already loaded.
   HRESULT registerBhoIfNeeded();
 };
 
 [
   object,
-  uuid(851bedec-4b2c-4959-abc0-a53403117257),
-  local,  // This interface should never be marshaled.
-  hidden,
-]
-// Internal implementation interface. Not intended as an API. May change
-// frequently, don't treat this as frozen.
-interface IChromeFrameInternal : IUnknown {
-  // This method is available only when the control is in privileged mode.
-  HRESULT getSessionId([out, retval] int* session_id);
-};
-
-[
-  object,
-  uuid(B1B52A4D-B22E-489f-8CCD-1CF9166FA90E),
+  uuid(E98FDFD9-312B-444a-A640-8E88F3CC08B8),
   oleautomation,
   nonextensible,
   hidden,
 ]
 // Internal implementation interface. Not intended as an API. May change
 // frequently, don't treat this as frozen.
 interface IChromeFramePrivileged : IUnknown {
   // If the host returns false for wants_privileged, the control
   // won't enable privileged mode.
   HRESULT GetWantsPrivileged([out] boolean *wants_privileged);
   // The profile name we want to use.
   HRESULT GetChromeProfileName([out] BSTR *profile_name);
-  // The comma-separated list of extension API functions you wish to automate.
-  // Return S_FALSE to leave the default, which is to not automate any 
-  // functions.
-  HRESULT GetExtensionApisToAutomate([out] BSTR *extension_apis);
   // Called when an automation version mismatch occurs. Returns S_OK if
   // a dialog should be showed to the user by this CF instance, S_FALSE if
   // not.
   HRESULT ShouldShowVersionMismatchDialog();
 };
 
 // Expose this service to the ChromeFrame control to trigger privileged
 // mode. If the control is in privileged mode, it will forward messages
 // to the onmessage handler irrespective of origin.
 cpp_quote("#define SID_ChromeFramePrivileged __uuidof(IChromeFramePrivileged)")
 
 typedef enum {
   CF_EVENT_DISPID_ONLOAD = 1,
   CF_EVENT_DISPID_ONLOADERROR,
   CF_EVENT_DISPID_ONMESSAGE,
   CF_EVENT_DISPID_ONPRIVATEMESSAGE,
-  CF_EVENT_DISPID_ONEXTENSIONREADY,
-  CF_EVENT_DISPID_ONGETENABLEDEXTENSIONSCOMPLETE,
   CF_EVENT_DISPID_ONCHANNELERROR,
   CF_EVENT_DISPID_ONCLOSE,
   CF_EVENT_DISPID_ONREADYSTATECHANGED = DISPID_READYSTATECHANGE,
 } ChromeFrameEventDispId;
 
 [
   uuid(6F2664E1-FF6E-488A-BCD1-F4CA6001DFCC),
   version(1.0),
   helpstring("ChromeTab 1.0 Type Library")
 ]
 library ChromeTabLib {
   importlib("stdole2.tlb");
 
-  [uuid(388B5D64-CE67-415b-9B0F-745C56E868E7)]
+  [uuid(812C601D-D787-49f2-BF05-6A460B44D2B3)]

[Sigurður Ásgeirsson, 2011/04/05 16:57:16]

I don't think this is necessary. As the interface here is a dispinterface.
There's no harm, that I can think of, however.

[Jói, 2011/04/05 17:04:17]

Yeah, I didn't think so either.  Just going by the book, so to speak :)

[Jói, 2011/04/05 19:24:45]

To be on the safe side (to leave the type library compatible with any clients
out there) I reverted the change of IID.

   dispinterface DIChromeFrameEvents {
    properties:
     // None.
 
    methods:
     [id(CF_EVENT_DISPID_ONLOAD)]
     void onload();
     
     [id(CF_EVENT_DISPID_ONLOADERROR)]
     void onloaderror();
     
     [id(CF_EVENT_DISPID_ONMESSAGE)]
     void onmessage([in] IDispatch* event);
     
     [id(CF_EVENT_DISPID_ONREADYSTATECHANGED)]
     void onreadystatechanged();
     
     [id(CF_EVENT_DISPID_ONPRIVATEMESSAGE)]
     // This event is only fired when the control is in privileged mode.
     void onprivatemessage([in] IDispatch* event, [in] BSTR target);
 
-    [id(CF_EVENT_DISPID_ONEXTENSIONREADY)]
-    // This event is only fired when the control is in privileged mode.
-    // response is one of AutomationMsg_ExtensionResponseValues.
-    void onextensionready([in] BSTR path, [in] long response);
-
-    [id(CF_EVENT_DISPID_ONGETENABLEDEXTENSIONSCOMPLETE)]
-    // This event is only fired when the control is in privileged mode.
-    // extension_paths is an array of BSTRs of the base directories of
-    // enabled extensions.
-    void ongetenabledextensionscomplete([in] SAFEARRAY(BSTR) extension_paths);
-
     [id(CF_EVENT_DISPID_ONCHANNELERROR)]
     // This event is fired when there is an error in communication channel with
     // Chrome and Automation must be reconnected to continue.
     void onchannelerror();
 
     [id(CF_EVENT_DISPID_ONCLOSE)]
     // This event is fired when the script inside the page wants to close it.
     // This is just a notification, there is no way to prevent the script from
     // closing.
     void onclose();
@@ skipping 18 matching lines @@
   coclass ChromeFrame {
     [default] interface IChromeFrame;
     [default, source] dispinterface DIChromeFrameEvents;
   };
 
   [uuid(ECB3C477-1A0A-44bd-BB57-78F9EFE34FA7)]
   coclass ChromeFrameBHO {
     [default] interface IUnknown;
   };
 };