Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 6756029: Clean up runtime functions. (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clean up runtime functions. Make all functions called from generated code declared using RUNTIME_FUNCTION macro. This makes them all look consistent and allows experimenting with various calling conventions. Committed: http://code.google.com/p/v8/source/detail?r=7439

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed the underscore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -699 lines) Patch
M src/arguments.h View 1 chunk +11 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/debug.cc View 5 chunks +37 lines, -37 lines 0 comments Download
M src/ic.cc View 11 chunks +11 lines, -23 lines 0 comments Download
M src/runtime.cc View 260 chunks +296 lines, -613 lines 0 comments Download
M src/stub-cache.h View 1 chunk +8 lines, -8 lines 0 comments Download
M src/stub-cache.cc View 7 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vitaly Repeshko
9 years, 8 months ago (2011-03-30 13:09:55 UTC) #1
Mads Ager (chromium)
I would love to get rid of the underscore. http://codereview.chromium.org/6756029/diff/1/src/serialize.h File src/serialize.h (right): http://codereview.chromium.org/6756029/diff/1/src/serialize.h#newcode41 src/serialize.h:41: ...
9 years, 8 months ago (2011-03-30 13:41:43 UTC) #2
Vitaly Repeshko
Removed the underscore. It did not cause conflicts. Please take another look. Thanks, Vitaly
9 years, 8 months ago (2011-03-30 14:00:05 UTC) #3
Mads Ager (chromium)
9 years, 8 months ago (2011-03-30 14:08:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698