Grit cleanup

Grit cleanup

- Fixup the chrome_strings target to default to a none target and let windows
  override it for it's hack.
- Make grit_target check _type to see how to auto add the header directory so
  it has a higher chance of being right in case things are done on real targets.

BUG=22247
TEST=everything still builds
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79562

[Mark Mentovai, 2011-03-28 15:14:55]

LGTM

In the change description, “in case” is always two words.

http://codereview.chromium.org/6756008/diff/1/build/grit_target.gypi
File build/grit_target.gypi (right):

http://codereview.chromium.org/6756008/diff/1/build/grit_target.gypi#newcode17
build/grit_target.gypi:17: ['_type=="executable" or _type=="shared_library" or \
Why didn’t you use _type=="none"? Because of that dummy_executable thing?

[TVL, 2011-03-28 15:17:08]

http://codereview.chromium.org/6756008/diff/1/build/grit_target.gypi
File build/grit_target.gypi (right):

http://codereview.chromium.org/6756008/diff/1/build/grit_target.gypi#newcode17
build/grit_target.gypi:17: ['_type=="executable" or _type=="shared_library" or \
On 2011/03/28 15:14:55, Mark Mentovai wrote:
> Why didn’t you use _type=="none"? Because of that dummy_executable thing?

yea, I've seen that and "settings" in files, so this seemed like the safer
method.