Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 6756003: Cleanup of HEAP and FACTORY macro usage in accessors.cc. (Closed)

Created:
9 years, 8 months ago by Peter Varga
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cleanup of HEAP and FACTORY macro usage in accessors.cc. BUG= TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the patch as Ager mentioned. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M src/accessors.cc View 1 6 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Varga
9 years, 8 months ago (2011-03-28 08:46:10 UTC) #1
Mads Ager (chromium)
http://codereview.chromium.org/6756003/diff/1/src/accessors.cc File src/accessors.cc (right): http://codereview.chromium.org/6756003/diff/1/src/accessors.cc#newcode122 src/accessors.cc:122: Isolate* isolate = Isolate::Current(); Please get the isolate from ...
9 years, 8 months ago (2011-03-28 12:59:52 UTC) #2
Peter Varga
The fixed patch is sent to the Patch Set 2. The server didn't send notification ...
9 years, 8 months ago (2011-03-28 14:09:05 UTC) #3
Vitaly Repeshko
9 years, 8 months ago (2011-03-29 06:55:02 UTC) #4
LGTM. I'll land.


Thanks,
Vitaly

Powered by Google App Engine
This is Rietveld 408576698